[on-demand] Turn monomorphic_const_eval into a proper query, not just a cache. #41310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #41319) made this pull request unmergeable. Please resolve the merge conflicts. |
eddyb
force-pushed
the
demand-const-eval
branch
from
68204ba to
6dc21b7
Compare
nikomatsakis
approved these changes
Apr 17, 2017
|
@bors r+ |
|
📌 Commit 6dc21b7 has been approved by |
|
Thanks @eddyb :) |
|
⌛ Testing commit 6dc21b7 with merge 88792cb... |
|
💔 Test failed - status-appveyor |
|
@bors: retry |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…akis [on-demand] Turn monomorphic_const_eval into a proper query, not just a cache. The error definitions and reporting logic, alongside with `eval_length` were moved to `librustc`. Both local and cross-crate constant evaluation is on-demand now, but the latter is only used for `enum` discriminants, to replace the manual insertion into the cache which was done when decoding variants. r? @nikomatsakis
|
☔ The latest upstream changes (presumably #41357) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r- |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error definitions and reporting logic, alongside with
eval_lengthwere moved tolibrustc.Both local and cross-crate constant evaluation is on-demand now, but the latter is only used for
enumdiscriminants, to replace the manual insertion into the cache which was done when decoding variants.r? @nikomatsakis