rustc_trans: do not treat byval as using up registers. #41378
Merged
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 0b35af9 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixes rust-lang#41375.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixes rust-lang#41375.
|
There's a travis failure @bors r- |
eddyb
force-pushed
the
byval-is-not-like-sret
branch
from
0b35af9 to
cba0c6a
Compare
|
@bors r=arielb1 |
|
📌 Commit cba0c6a has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixes rust-lang#41375.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 19, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixes rust-lang#41375.
eddyb
added
the
beta-nominated
aidanhs
added
the
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 20, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixes rust-lang#41375.
eddyb
added
T-compiler
nikomatsakis
added
the
beta-accepted
|
Marking as beta-accepted. Small, blocks servo/firefox FFI. cc @rust-lang/compiler |
alexcrichton
removed
the
beta-nominated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps not that well-documented,
byvalpointer arguments are not the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the contents on the stack.Fixes #41375.