Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't panic if an attribute macro fails to resolve at crate root #41432

Merged
merged 1 commit into from
Apr 22, 2017

Conversation

abonander
Copy link
Contributor

Adds temporary regression test; this ideally should work as-is (#41430)

Closes #41211

r? @jseyfried

Adds temporary regression test; this ideally should work as-is (rust-lang#41430)

Closes rust-lang#41211
@shepmaster
Copy link
Member

Thanks @abonander! We'll check up on this PR periodically to make sure that @jseyfried or another reviewer gets to it in a timely manner!

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2017
@jseyfried
Copy link
Contributor

@abonander Thanks, looks good!
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 21, 2017

📌 Commit 910532e has been approved by jseyfried

@shepmaster shepmaster added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 22, 2017
Don't panic if an attribute macro fails to resolve at crate root

Adds temporary regression test; this ideally should work as-is (rust-lang#41430)

Closes rust-lang#41211

r? @jseyfried
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 22, 2017
Don't panic if an attribute macro fails to resolve at crate root

Adds temporary regression test; this ideally should work as-is (rust-lang#41430)

Closes rust-lang#41211

r? @jseyfried
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 22, 2017
Don't panic if an attribute macro fails to resolve at crate root

Adds temporary regression test; this ideally should work as-is (rust-lang#41430)

Closes rust-lang#41211

r? @jseyfried
bors added a commit that referenced this pull request Apr 22, 2017
Rollup of 4 pull requests

- Successful merges: #37658, #41405, #41432, #41435
- Failed merges:
@bors bors merged commit 910532e into rust-lang:master Apr 22, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants