Skip to content

Clean up TcpStream example #41526

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Clean up TcpStream example #41526

merged 1 commit into from
Apr 28, 2017

Conversation

steveklabnik
Copy link
Member

Fixes #35950

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 25, 2017

📌 Commit ca96892 has been approved by GuillaumeGomez

arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
@frewsxcv frewsxcv added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Apr 25, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
@GuillaumeGomez
Copy link
Member

Failure:

[01:05:37] ---- net/tcp.rs - net::tcp::TcpListener (line 75) stdout ----
[01:05:37] 	error[E0434]: can't capture dynamic environment in a fn item; use the || { ... } closure form instead
[01:05:37]   --> <anon>:15:15
[01:05:37]    |
[01:05:37] 15 | for stream in listener.incoming() {
[01:05:37]    |               ^^^^^^^^
[01:05:37] 
[01:05:37] error: aborting due to previous error(s)

@bors: r-

@@ -72,24 +72,23 @@ pub struct TcpStream(net_imp::TcpStream);
///
/// # Examples
///
/// ```no_run
/// ```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: I removed the no_run because now that the work is being done inside of process, which is never called, "running" this code doesn't really do much anyway.

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2017
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 27, 2017

📌 Commit 7b7fe9b has been approved by GuillaumeGomez

arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 27, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 27, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 27, 2017
bors added a commit that referenced this pull request Apr 28, 2017
Rollup of 7 pull requests

- Successful merges: #41438, #41523, #41526, #41546, #41556, #41572, #41578
- Failed merges:
@bors bors merged commit 7b7fe9b into rust-lang:master Apr 28, 2017
@steveklabnik steveklabnik deleted the gh35950 branch October 25, 2017 18:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants