Skip to content

Add markdown-[before|after]-content options #41826

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 14, 2017

Conversation

GuillaumeGomez
Copy link
Member

cc @nical

r? @rust-lang/docs

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2017
@frewsxcv
Copy link
Member

frewsxcv commented May 9, 2017

out of curiosity, what's the use case here? is there some reasoning behind this change?

@GuillaumeGomez
Copy link
Member Author

It's just to allow to pass markdown as well instead of just html.

@frewsxcv
Copy link
Member

seems alright to me, though I'm still curious what the use case is

considering these are unstable options, and the diff here is pretty small, i don't think this needs to be held up

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 13, 2017

📌 Commit 95a94e3 has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 13, 2017
…, r=frewsxcv

Add markdown-[before|after]-content options

cc @nical

r? @rust-lang/docs
bors added a commit that referenced this pull request May 13, 2017
Rollup of 5 pull requests

- Successful merges: #41826, #41919, #41946, #41967, #41969
- Failed merges: #41939
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 13, 2017
…, r=frewsxcv

Add markdown-[before|after]-content options

cc @nical

r? @rust-lang/docs
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 14, 2017
…, r=frewsxcv

Add markdown-[before|after]-content options

cc @nical

r? @rust-lang/docs
bors added a commit that referenced this pull request May 14, 2017
Rollup of 7 pull requests

- Successful merges: #41612, #41826, #41939, #41946, #41950, #41975, #41979
- Failed merges:
@bors bors merged commit 95a94e3 into rust-lang:master May 14, 2017
@GuillaumeGomez GuillaumeGomez deleted the add-markdown-content branch May 14, 2017 10:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants