Skip to content

Fix regression in macro_rules! name matching #42005

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2017
Merged

Fix regression in macro_rules! name matching #42005

merged 1 commit into from
May 16, 2017

Conversation

jseyfried
Copy link
Contributor

Fixes #41803.
r? @nrc

@jseyfried jseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 15, 2017
@jseyfried jseyfried mentioned this pull request May 15, 2017
Closed
@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2017
@jseyfried jseyfried mentioned this pull request May 15, 2017
Closed
@nrc
Copy link
Member

nrc commented May 16, 2017

@bors: r+

@bors
Copy link
Collaborator

bors commented May 16, 2017

📌 Commit 9f4e1e1 has been approved by nrc

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 16, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42005 - jseyfried:fix_macro_regression, r=nrc
747f7d2 
Fix regression in `macro_rules!` name matching

Fixes rust-lang#41803.
r? @nrc
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 16, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 16, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42005 - jseyfried:fix_macro_regression, r=nrc
6b4f3a7 
Fix regression in `macro_rules!` name matching

Fixes rust-lang#41803.
r? @nrc
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 16, 2017
Merged
@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2017
bors added a commit that referenced this pull request May 16, 2017
@bors
Auto merge of #42038 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
0f68728 
Rollup of 8 pull requests

- Successful merges: #41489, #41982, #41994, #41995, #42001, #42005, #42011, #42028
- Failed merges:
@bors bors merged commit 9f4e1e1 into rust-lang:master May 16, 2017
@jseyfried jseyfried deleted the fix_macro_regression branch May 17, 2017 03:50
@michaelwoerister
Copy link
Member

Discussed in the compiler team meeting: backporting seems like a good idea.

@michaelwoerister michaelwoerister added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 18, 2017
@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 1, 2017
@alexcrichton alexcrichton mentioned this pull request Jun 1, 2017
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 1, 2017
bors added a commit that referenced this pull request Jun 1, 2017
@bors
Auto merge of #42364 - alexcrichton:beta-next, r=brson
38eab2e 
[beta] Fix regression in `macro_rules!` name matching.

This is a backport of #42005
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jseyfried @nrc @bors @michaelwoerister @brson @carols10cents @arielb1