Skip to content

Beta backport various arielb1 patches #42053

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2017
Merged

Beta backport various arielb1 patches #42053

merged 2 commits into from
May 23, 2017

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented May 17, 2017 •
edited
Loading

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

This was referenced May 17, 2017
Merged
Merged
Merged
@eddyb
Copy link
Member

eddyb commented May 17, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented May 17, 2017

📌 Commit 49138b4 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented May 17, 2017

⌛ Testing commit 49138b4 with merge fb9ba8d...

@bors
Copy link
Collaborator

bors commented May 17, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

@bors retry

  • Build just stopped

@alexcrichton
Copy link
Member

@bors: r-

Looks like a legitimate error?

[00:48:58] test [run-pass] run-pass/issue-41696.rs has been running for over 60 seconds
...
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

@aidanhs aidanhs added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2017
@michaelwoerister michaelwoerister mentioned this pull request May 18, 2017
Closed
@nikomatsakis
Copy link
Contributor Author

@arielb1 any idea why the backport [doesn't fix the problem for #41696](#42053 (comment)? is it maybe specific to what version of LLVM the beta is using or something?

@nikomatsakis
Copy link
Contributor Author

Removed #41920

@nikomatsakis
Copy link
Contributor Author

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented May 22, 2017

📌 Commit 0afe53e has been approved by eddyb

@nikomatsakis
Copy link
Contributor Author

@bors p=1

@bors
Copy link
Collaborator

bors commented May 22, 2017

⌛ Testing commit 0afe53e with merge 191cde0...

bors added a commit that referenced this pull request May 22, 2017
@bors
Auto merge of #42053 - nikomatsakis:beta, r=eddyb
191cde0 
Beta backport various arielb1 patches

Backport of the following PRs:

- #41651
- #41828

cc @arielb1 @rust-lang/compiler
@bors
Copy link
Collaborator

bors commented May 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 191cde0 to beta...

@bors bors merged commit 0afe53e into rust-lang:beta May 23, 2017
@est31 est31 mentioned this pull request May 23, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nikomatsakis @rust-highfive @eddyb @bors @Mark-Simulacrum @alexcrichton @pnkfelix @aidanhs @arielb1