Rollup of 6 pull requests #42130
Merged
Rollup of 6 pull requests #42130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when compiling the crate for a target with max-atomic-width = 0 fixes rust-lang#42097
expose needs_drop under mem Note that I purposefully didn't update the intrinsic's documentation, because I think it makes sense for it be more... "honest" about its semantics.
…omatsakis Fix off-by-one error in column number in `explain_span`. Fixes rust-lang#41938
Improving std::env docs Addresses rust-lang#29351. Hopefully this addresses the following points: > - iterators should use the standard iterator boilerplate like https://doc.rust-lang.org/std/iter/struct.Map.html, this applies to all structs except for JoinPathsError > - JoinPathsError should properly link the function it comes from and use language similar to https://doc.rust-lang.org/std/io/struct.Error.html > - same wording issues with VarError > - functions need to ensure linkage to things they refer to in their descriptions > - Explain the difference between `os` and non-`os` structs and methods
…ielb1 fix some clippy warnings in librustc_errors Again, those are small changes to improve readability.
core: fix unused_macro warning when compiling the crate for a target with max-atomic-width = 0 fixes rust-lang#42097
Remove unused lifetimes. This was a typo that made it onto master. Noted by @dtolnay in rust-lang#42127. Also note rust-lang#41960 which suggests warning these.
|
@bors r+ p=10 |
|
📌 Commit 382c0eb has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explain_span. #42062, Improving std::env docs #42091, fix some clippy warnings in librustc_errors #42093, core: fix unused_macro warning #42098, Remove unused lifetimes. #42127