Skip to content

rustdoc: Fix names of items in cross crate reexported modules #42145

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2017
Merged

rustdoc: Fix names of items in cross crate reexported modules #42145

merged 1 commit into from
May 23, 2017

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented May 22, 2017 •
edited
Loading

For renamed reexports the new name should be used.

An example of this (as pointed out in #27741 (comment)) is two instances of StepBy in std::iter. core::iter is correct.

Fixes #37608

@ollie27
rustdoc: Fix names of items in cross crate reexported modules
0cb6a1f 
For renamed reexports the new name should be used.
@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv frewsxcv added the T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. label May 22, 2017
@steveklabnik
Copy link
Member

Nice, thank you!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 22, 2017

📌 Commit 0cb6a1f has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented May 22, 2017

⌛ Testing commit 0cb6a1f with merge 97b779f...

@steveklabnik
Copy link
Member

@bors: rollup- (Actually maybe this is best not a rollup)

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 22, 2017
@bors
Copy link
Collaborator

bors commented May 22, 2017

💔 Test failed - status-appveyor

@Mark-Simulacrum
Copy link
Member

@bors retry

  • timed out

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 23, 2017
@frewsxcv
Rollup merge of rust-lang#42145 - ollie27:rustdoc_inline_renamed, r=s…
b2c7423 
…teveklabnik

rustdoc: Fix names of items in cross crate reexported modules

For renamed reexports the new name should be used.

An example of this (as pointed out in rust-lang#27741 (comment)) is two instances of `StepBy` in [`std::iter`](https://doc.rust-lang.org/nightly/std/iter/index.html#structs). [`core::iter`](https://doc.rust-lang.org/nightly/core/iter/index.html#structs) is correct.

Fixes rust-lang#37608
@frewsxcv frewsxcv mentioned this pull request May 23, 2017
Merged
bors added a commit that referenced this pull request May 23, 2017
@bors
Auto merge of #42165 - frewsxcv:rollup, r=frewsxcv
852b7cb 
Rollup of 8 pull requests

- Successful merges: #42016, #42122, #42144, #42145, #42151, #42152, #42160, #42163
- Failed merges:
@bors bors merged commit 0cb6a1f into rust-lang:master May 23, 2017
@ollie27 ollie27 deleted the rustdoc_inline_renamed branch May 23, 2017 07:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ollie27 @rust-highfive @steveklabnik @bors @Mark-Simulacrum @carols10cents @frewsxcv