Skip to content

[beta] box large variants in MIR #42197

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2017
Merged

[beta] box large variants in MIR #42197

merged 2 commits into from
May 26, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented May 24, 2017 •
edited
Loading

Beta backport of #41926.

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?

@arielb1
box large variants in MIR
74fe27f 
Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 24, 2017

📌 Commit 74fe27f has been approved by nikomatsakis

@aidanhs
Copy link
Member

aidanhs commented May 24, 2017

(not a legit PR build failure, it just failed to clone (#42117) on the OSX builder which wouldn't do anything anyway. Nothing to to retry since bors hasn't had a look yet)

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 24, 2017
@aidanhs
Copy link
Member

aidanhs commented May 24, 2017

(realised I have the power to retry jobs, so I did so and all is green)

@brson
Copy link
Contributor

brson commented May 25, 2017

@bors p=1

@bors
Copy link
Collaborator

bors commented May 25, 2017

⌛ Testing commit 74fe27f with merge f40fad5...

@bors
Copy link
Collaborator

bors commented May 25, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: r=nikomatsakis

@bors
Copy link
Collaborator

bors commented May 25, 2017

📌 Commit ea239f2 has been approved by nikomatsakis

@bors
Copy link
Collaborator

bors commented May 25, 2017

⌛ Testing commit ea239f2 with merge cf77445...

@alexcrichton alexcrichton mentioned this pull request May 25, 2017
Merged
@bors
Copy link
Collaborator

bors commented May 25, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

@bors: retry

  • ar.exe error fixed on master

@bors
Copy link
Collaborator

bors commented May 25, 2017

⌛ Testing commit ea239f2 with merge e9f90f7...

@bors
Copy link
Collaborator

bors commented May 25, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented May 26, 2017

⌛ Testing commit ea239f2 with merge 4644612...

bors added a commit that referenced this pull request May 26, 2017
@bors
Auto merge of #42197 - arielb1:box-mir-beta, r=nikomatsakis
4644612 
[beta] box large variants in MIR

Beta backport of #41926.

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
@bors
Copy link
Collaborator

bors commented May 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4644612 to beta...

@bors bors merged commit ea239f2 into rust-lang:beta May 26, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@arielb1 @rust-highfive @nikomatsakis @bors @aidanhs @brson @alexcrichton @Mark-Simulacrum