Skip to content

rustdoc: Hide self: Box<Self> in list of deref methods #42394

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jun 2, 2017

These methods can never be called through deref so there is no point including them. For example you can't call into_boxed_bytes or into_string on String.

These methods can never be called through deref so there is no point
including them. For example you can't call `into_boxed_bytes` or
`into_string` on `String`.
@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2017
@QuietMisdreavus
Copy link
Member

Nice catch!

@bors r+

(I don't think I actually have r+ access yet, but I'm stating it here anyway for the record >_>)

@Mark-Simulacrum
Copy link
Member

@bors r=QuietMisdreavus (rust-lang/rust-central-station#12)

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

📌 Commit 88c791b has been approved by QuietMisdreavus

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2017
@bors
Copy link
Collaborator

bors commented Jun 4, 2017

⌛ Testing commit 88c791b with merge c5dcc65...

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

LLDB segfaulted? https://travis-ci.org/rust-lang/rust/jobs/239280446#L8493

@bors retry

[01:11:15] version
[01:11:15] lldb-360.1.70 
[01:11:15] command script import /Users/travis/build/rust-lang/rust/./src/etc/lldb_rust_formatters.py
[01:11:15] type summary add --no-value --python-function lldb_rust_formatters.print_val -x ".*" --category Rust
[01:11:15] type category enable Rust
[01:11:15] 
[01:11:15] breakpoint set --file 'lexical-scope-in-if.rs' --line 144
[01:11:15] Breakpoint 1: where = lexical-scope-in-if.stage2-i686-apple-darwin`lexical_scope_in_if::main + 27 at lexical-scope-in-if.rs:144, address = 0x00002b6b 
[01:11:15] breakpoint set --file 'lexical-scope-in-if.rs' --line 148
[01:11:15] Breakpoint 2: where = lexical-scope-in-if.stage2-i686-apple-darwin`lexical_scope_in_if::main + 49 at lexical-scope-in-if.rs:148, address = 0x00002b81 
[01:11:15] breakpoint set --file 'lexical-scope-in-if.rs' --line 153
[01:11:15] Breakpoint 3: where = lexical-scope-in-if.stage2-i686-apple-darwin`lexical_scope_in_if::main + 111 at lexical-scope-in-if.rs:153, address = 0x00002bbf 
[01:11:15] breakpoint set --file 'lexical-scope-in-if.rs' --line 158
[01:11:15] Breakpoint 4: where = lexical-scope-in-if.stage2-i686-apple-darwin`lexical_scope_in_if::main + 135 at lexical-scope-in-if.rs:158, address = 0x00002bd7 
[01:11:15] breakpoint set --file 'lexical-scope-in-if.rs' --line 164
[01:11:15] Breakpoint 5: where = lexical-scope-in-if.stage2-i686-apple-darwin`lexical_scope_in_if::main + 145 at lexical-scope-in-if.rs:164, address = 0x00002be1 
[01:11:15] breakpoint set --file 'lexical-scope-in-if.rs' --line 170
[01:11:15] Breakpoint 6: where = lexical-scope-in-if.stage2-i686-apple-darwin`lexical_scope_in_if::main + 207 at lexical-scope-in-if.rs:170, address = 0x00002c1f 
[01:11:15] breakpoint set --file 'lexical-scope-in-if.rs' --line 175
[01:11:15] Breakpoint 7: where = lexical-scope-in-if.stage2-i686-apple-darwin`lexical_scope_in_if::main + 231 at lexical-scope-in-if.rs:175, address = 0x00002c37 
[01:11:15] breakpoint set --file 'lexical-scope-in-if.rs' --line 179
[01:11:15] Breakpoint 8: where = lexical-scope-in-if.stage2-i686-apple-darwin`lexical_scope_in_if::main + 241 at lexical-scope-in-if.rs:179, address = 0x00002c41 
[01:11:15] quit

@carols10cents
Copy link
Member

Uhhhhhh it looks like LLVM segfaulted again, so I'm reluctant to just retry it again, but I have no idea if it's possible that this is related or not... @alexcrichton do you know?

@alexcrichton
Copy link
Member

@bors: retry

I think the earlier retry may have been dropped?

@bors
Copy link
Collaborator

bors commented Jun 6, 2017

⌛ Testing commit 88c791b with merge 17f493f...

bors added a commit that referenced this pull request Jun 6, 2017
rustdoc: Hide `self: Box<Self>` in list of deref methods

These methods can never be called through deref so there is no point including them. For example you can't call [`into_boxed_bytes`](https://doc.rust-lang.org/nightly/std/string/struct.String.html#method.into_boxed_bytes) or [`into_string`](https://doc.rust-lang.org/nightly/std/string/struct.String.html#method.into_string) on `String`.
@bors
Copy link
Collaborator

bors commented Jun 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 17f493f to master...

@bors bors merged commit 88c791b into rust-lang:master Jun 6, 2017
@ollie27 ollie27 deleted the rustdoc_deref_box branch June 6, 2017 12:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants