Emit a type error for integer literals where the expected type is char #4268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, in let x: char = 42; This was an ICE and is now a proper type error, as per rust-lang#3477
|
r+ |
|
Sorry it took so long |
|
No prob, I had forgotten you were on vacation. (And still are! Stop working! ;-) |
catamorphism
added a commit
that referenced
this pull request
Dec 28, 2012
Emit a type error for integer literals where the expected type is char
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Apr 14, 2025
Fix Build Fail on MacOs because of libffi-sys
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson As per #3477, emit a proper type error instead of ICEing for a situation where the inferred type is integral and the expected type is
char(likelet x: char = 42).