Skip to content

Better Debug for Args and ArgsOs #42798

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Conversation

stepancheg
Copy link
Contributor

Display actual args instead of two dots.

Display actual args instead of two dots.
@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@stepancheg
Copy link
Contributor Author

I didn't check it on Windows. Is there a way to ask some build system to check it?

@Mark-Simulacrum
Copy link
Member

Not really; well, the code will be compiled and tested on Windows when r+-ed. With the right toolchains locally that's not an issue, but I wouldn't worry about it.

@stepancheg
Copy link
Contributor Author

stepancheg commented Jun 21, 2017

With the right toolchains locally that's not an issue

What do you mean? Maybe I don't know something? I tried to compile Rust in VirtualBox, and couldn't make it work. E. g.

2017-06-21_1817

Edit: this particular issue fixed somehow.

@stepancheg
Copy link
Contributor Author

OK, I managed to compile it under VirtualBox and fixed it.

@sfackler
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 21, 2017

📌 Commit 14c8184 has been approved by sfackler

@stepancheg
Copy link
Contributor Author

Test seems to be broken on Linux. Seems like args is empty on Linux. Trying to reproduce it now on Linux.

@Mark-Simulacrum
Copy link
Member

@bors r-

@stepancheg
Copy link
Contributor Author

stepancheg commented Jun 21, 2017

Should be OK now. Do r+ somebody, please.

@sfackler
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 21, 2017

📌 Commit 275f9a0 has been approved by sfackler

@frewsxcv
Copy link
Member

@bors rollup

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 22, 2017
Better Debug for Args and ArgsOs

Display actual args instead of two dots.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 22, 2017
Better Debug for Args and ArgsOs

Display actual args instead of two dots.
@bors
Copy link
Collaborator

bors commented Jun 22, 2017

⌛ Testing commit 275f9a0 with merge 6f01c84...

bors added a commit that referenced this pull request Jun 22, 2017
Better Debug for Args and ArgsOs

Display actual args instead of two dots.
@bors
Copy link
Collaborator

bors commented Jun 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 6f01c84 to master...

@bors bors merged commit 275f9a0 into rust-lang:master Jun 22, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants