change binding name of for loop lowering to appease clippy #42871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest change to for loop lowering, a `_next` binding was introduced. Unfortunately, this disturbs clippy's `used_underscore_binding` lint. This commit just renames the binding to `__next` so clippy will be happy. It should have no other effect.
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
added
the
S-waiting-on-review
|
Note that the right way to solve this would be #39766 but progress on that appears to have stalled, so this would be a simple and effective stop-gap measure. |
|
@bors r+ |
|
📌 Commit ebe71fd has been approved by |
|
@bors rollup |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 27, 2017
…ielb1 change binding name of for loop lowering to appease clippy With the latest change to for loop lowering (rust-lang#42634), a `_next` binding was introduced. Unfortunately, this [disturbs](https://github.com/Manishearth/rust-clippy/issues/1846) clippy's `used_underscore_binding` lint. This commit just renames the binding to `__next` so clippy will be happy. It should have no other effect.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest change to for loop lowering (#42634), a
_nextbinding was introduced.Unfortunately, this disturbs clippy's
used_underscore_bindinglint. This commit just renames the binding to__nextso clippy will be happy. It should have no other effect.