Skip to content

re-add the call to super_statement in EraseRegions #42931

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2017
Merged

re-add the call to super_statement in EraseRegions #42931

merged 1 commit into from
Jun 28, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Jun 27, 2017

The move gathering code is sensitive to type-equality - that is rather
un-robust and I plan to fix it eventually, but that's a more invasive
change. And we want to fix the visitor anyway.

Fixes #42903.

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Jun 27, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

📌 Commit dded9e9 has been approved by eddyb

@arielb1
Copy link
Contributor Author

arielb1 commented Jun 27, 2017

@bors p=100

This unbreaks the nightly

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

⌛ Testing commit dded9e91ee8d9b73442b64d4c0a2dab06969ac75 with merge c2b9827c84175162f9d65b01857c380b5f87a63d...

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

[00:01:37] curl: (56) SSLRead() return error -36

@bors retry

@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 27, 2017
@bors
Copy link
Collaborator

bors commented Jun 27, 2017

⌛ Testing commit dded9e91ee8d9b73442b64d4c0a2dab06969ac75 with merge fbb85a9948e8757a3a57b67358247674d78cf9ba...

@bors
Copy link
Collaborator

bors commented Jun 28, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member 

[01:15:43] stderr:
[01:15:43] ------------------------------------------
[01:15:43] error: unexpected token: `0.0`
[01:15:43]   --> <anon>:98:15
[01:15:43]    |
[01:15:43] 98 |     let f = x.0.0;
[01:15:43]    |             --^^^
[01:15:43]    |             | |
[01:15:43]    |             | unexpected token
[01:15:43]    |             help: try parenthesizing the first index `(x.0).0`
[01:15:43] 
[01:15:43] error: unexpected token: `0.0`
[01:15:43]   --> <anon>:99:15
[01:15:43]    |
[01:15:43] 99 |     if c0 { x.0.0 = f; }
[01:15:43]    |             --^^^
[01:15:43]    |             | |
[01:15:43]    |             | unexpected token
[01:15:43]    |             help: try parenthesizing the first index `(x.0).0`
[01:15:43] 
[01:15:43] error: aborting due to previous error(s)
[01:15:43] 
[01:15:43] 
[01:15:43] ------------------------------------------
[01:15:43] 
[01:15:43] thread '[pretty] pretty/dynamic-drop.rs' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:2479
[01:15:43] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:15:43] 
[01:15:43] 
[01:15:43] failures:
[01:15:43]     [pretty] pretty/dynamic-drop.rs
[01:15:43] 
[01:15:43] test result: FAILED. 2669 passed; 1 failed; 36 ignored; 0 measured; 0 filtered out
[01:15:43]

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 28, 2017
@arielb1
re-add the call to super_statement in EraseRegions
71abfa7 
The move gathering code is sensitive to type-equality - that is rather
un-robust and I plan to fix it eventually, but that's a more invasive
change. And we want to fix the visitor anyway.

Fixes rust-lang#42903.
@arielb1 arielb1 force-pushed the statement-visitor branch from dded9e9 to 71abfa7 Compare June 28, 2017 08:02
@arielb1
Copy link
Contributor Author

arielb1 commented Jun 28, 2017

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Jun 28, 2017

📌 Commit 71abfa7 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jun 28, 2017

⌛ Testing commit 71abfa7 with merge 6b52a11...

bors added a commit that referenced this pull request Jun 28, 2017
@bors
Auto merge of #42931 - arielb1:statement-visitor, r=eddyb
6b52a11 
re-add the call to `super_statement` in EraseRegions

The move gathering code is sensitive to type-equality - that is rather
un-robust and I plan to fix it eventually, but that's a more invasive
change. And we want to fix the visitor anyway.

Fixes #42903.

r? @eddyb
@pnkfelix
Copy link
Member

@arielb1 thanks for the quick fix. Super embarrassing oversight on my part. :(

@bors
Copy link
Collaborator

bors commented Jun 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 6b52a11 to master...

@bors bors merged commit 71abfa7 into rust-lang:master Jun 28, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moved value gets dropped if reassigned
5 participants
@arielb1 @eddyb @bors @Mark-Simulacrum @pnkfelix