Implement fs::rename in sys::redox #43204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
durka
reviewed
Jul 13, 2017
src/libstd/sys/redox/fs.rs
Outdated
| @@ -384,8 +384,9 @@ pub fn unlink(p: &Path) -> io::Result<()> { | |||
| } | |||
|
|
|||
| pub fn rename(_old: &Path, _new: &Path) -> io::Result<()> { | |||
There was a problem hiding this comment.
you forgot to rename the arguments
There was a problem hiding this comment.
thanks for the reminder @durka
codyps
reviewed
Jul 13, 2017
src/libstd/sys/redox/fs.rs
Outdated
| unimplemented!(); | ||
| copy(old, new)?; | ||
| unlink(old)?; | ||
| Ok(()) |
There was a problem hiding this comment.
The 2 proceeding lines could be reduced to unlink(old)
|
@bors: r+ rollup |
|
📌 Commit 4259ae6 has been approved by |
|
Thanks! |
alexcrichton
added
the
S-waiting-on-bors
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 13, 2017
Implement fs::rename in sys::redox This uses a simple implementation of copy + unlink. Redox does not have a rename or link system call for a faster implementation.
bors
added a commit
that referenced
this pull request
Jul 14, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a simple implementation of copy + unlink. Redox does not have a rename or link system call for a faster implementation.