Skip to content

Use a config struct for save-analysis #43327

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 24, 2017
Merged

Use a config struct for save-analysis #43327

merged 8 commits into from
Jul 24, 2017

Conversation

nrc
Copy link
Member

@nrc nrc commented Jul 19, 2017

Replaces some existing customisation options, including removing the -Zsave-analysis-api flag

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Jul 19, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 19, 2017

📌 Commit 696ded6 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jul 19, 2017

⌛ Testing commit 696ded6a81868b2fecb1b279b3a3f3fb233c9f19 with merge 0ec451a300267436acf995938fe41527dc79a7a3...

@bors
Copy link
Collaborator

bors commented Jul 19, 2017

💔 Test failed - status-appveyor

@nagbot-rs
Copy link

nagbot-rs commented Jul 19, 2017 via email

@bors
Copy link
Collaborator

bors commented Jul 19, 2017

@nagbot-rs: 🔑 Insufficient privileges: and not in try users

@alexcrichton
Copy link
Member

@bors: retry

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 20, 2017
@ishitatsuyuki
Copy link
Contributor

I think tidy is failing first of all.

@nrc
Copy link
Member Author

nrc commented Jul 21, 2017

@bors: r=@eddyb

@bors
Copy link
Collaborator

bors commented Jul 21, 2017

📌 Commit 6dcceab has been approved by @eddyb

@bors
Copy link
Collaborator

bors commented Jul 21, 2017

⌛ Testing commit 6dcceab74ccf32468a4d8bcd5fe341597ab259d1 with merge 7ab446657f61bf7de52a0052dc7151fac0b9b45a...

@bors
Copy link
Collaborator

bors commented Jul 21, 2017

💔 Test failed - status-travis

@aidanhs
Copy link
Member

aidanhs commented Jul 21, 2017 

[00:20:13] error: unknown debugging option: `save-analysis-api`

Seems legit

@shepmaster shepmaster added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2017
@bors
Copy link
Collaborator

bors commented Jul 21, 2017

☔ The latest upstream changes (presumably #43319) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc
Copy link
Member Author

nrc commented Jul 22, 2017

@bors: r=eddyb

@bors
Copy link
Collaborator

bors commented Jul 22, 2017

📌 Commit a941e69 has been approved by eddyb

@nrc nrc added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2017
@bors
Copy link
Collaborator

bors commented Jul 22, 2017

⌛ Testing commit a941e69d9df95d9b353a0697fde32b49eba3db6e with merge 930125026a81259621e68bf0e663333086c993b0...

@bors
Copy link
Collaborator

bors commented Jul 22, 2017

💔 Test failed - status-travis

@nrc
Copy link
Member Author

nrc commented Jul 24, 2017

@bors: r=eddyb

@bors
Copy link
Collaborator

bors commented Jul 24, 2017

📌 Commit 587a35d has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jul 24, 2017

⌛ Testing commit 587a35d with merge 513906c...

bors added a commit that referenced this pull request Jul 24, 2017
@bors
Auto merge of #43327 - nrc:rls-config, r=eddyb
513906c 
Use a config struct for save-analysis

Replaces some existing customisation options, including removing the -Zsave-analysis-api flag

r? @eddyb
@bors bors mentioned this pull request Jul 24, 2017
Merged
@bors
Copy link
Collaborator

bors commented Jul 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 513906c to master...

@bors bors merged commit 587a35d into rust-lang:master Jul 24, 2017
@bors bors mentioned this pull request Jul 24, 2017
Merged
Xanewok added a commit to rust-lang/rls that referenced this pull request Oct 23, 2017
@Xanewok
Mention RUSTC_SAVE_ANALYSIS in contributing.md
c2345e3 
The flag was changed in rust-lang/rust#43327.

r? @nrc
@Xanewok Xanewok mentioned this pull request Oct 23, 2017
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nrc @eddyb @bors @nagbot-rs @alexcrichton @ishitatsuyuki @aidanhs @shepmaster