Emphasise that these functions look at the disk, not just the path #43614
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Seems reasonable to me! @bors r+ |
|
📌 Commit 4792d28 has been approved by |
|
@bors rollup |
Emphasise that these functions look at the disk, not just the path
I thought that `PathBuf::new("foo/bar/").is_dir()` is always true, because the path ends in `/`. However, this is not what `is_dir()` function does. So I've updated the docs to make it clear.
|
☀️ Test successful - status-appveyor, status-travis |
I thought that
PathBuf::new("foo/bar/").is_dir()is always true, because the path ends in/. However, this is not whatis_dir()function does. So I've updated the docs to make it clear.