Skip to content

Remove Splice struct return value from String::splice #44044

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2017
Merged

Remove Splice struct return value from String::splice #44044

merged 1 commit into from
Aug 31, 2017

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Aug 22, 2017 •
edited
Loading

The implementation is now almost identical to the one in the RFC.

Fixes #44038
cc #32310

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2017
@estebank
Copy link
Contributor

@mattico It looks good to me. Could you squash the three commits?

@mattico mattico force-pushed the string-splice-return branch from 4450c93 to 0c3c43c Compare August 26, 2017 20:08
@dtolnay dtolnay assigned dtolnay and unassigned aturon Aug 30, 2017
@dtolnay
Copy link
Member

dtolnay commented Aug 30, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 30, 2017

📌 Commit 0c3c43c has been approved by dtolnay

@bors
Copy link
Collaborator

bors commented Aug 30, 2017

⌛ Testing commit 0c3c43c with merge 7b4bf09e37067540b325ee272f5819b8454006f4...

@bors
Copy link
Collaborator

bors commented Aug 30, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 30, 2017
@alexcrichton
Rollup merge of rust-lang#44044 - mattico:string-splice-return, r=dto…
581dc93 
…lnay

Remove Splice struct return value from String::splice

The implementation is now almost identical to the one in the RFC.

Fixes rust-lang#44038
cc rust-lang#32310
@alexcrichton alexcrichton mentioned this pull request Aug 30, 2017
Merged
bors added a commit that referenced this pull request Aug 31, 2017
@bors
Auto merge of #44186 - alexcrichton:rollup, r=alexcrichton
890c87b 
Rollup of 8 pull requests

- Successful merges: #44044, #44089, #44116, #44125, #44154, #44157, #44160, #44172
- Failed merges: #44162
@bors bors merged commit 0c3c43c into rust-lang:master Aug 31, 2017
@mattico mattico deleted the string-splice-return branch August 31, 2017 17:31
@dtolnay dtolnay mentioned this pull request Sep 17, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@dtolnay dtolnay

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mattico @rust-highfive @estebank @dtolnay @bors @alexcrichton @aturon @aidanhs