Skip to content

bootstrap: remove unneeded extern crate #44121

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

ishitatsuyuki
Copy link
Contributor

The crate itself is internally referenced by serde_derive.

The crate itself is internally referenced by serde_derive.
@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 28, 2017

📌 Commit 45d31ac has been approved by Mark-Simulacrum

@arielb1 arielb1 added beta-nominated Nominated for backporting to the compiler in the beta channel. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 28, 2017
@arielb1
Copy link
Contributor

arielb1 commented Aug 28, 2017

I think we want this on 1.21 too - if #42588 makes the cut to 1.21.

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 28, 2017
@bors
Copy link
Collaborator

bors commented Aug 28, 2017

⌛ Testing commit 45d31ac with merge 1d8b0c548dcd8453ed077d6ba4bc251cb0188c45...

@Mark-Simulacrum
Copy link
Member

I'm marking as beta-approved. Doesn't necessarily need to be backported, but wouldn't hurt.

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 28, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 29, 2017
… r=Mark-Simulacrum

bootstrap: remove unneeded extern crate

The crate itself is internally referenced by serde_derive.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 29, 2017
… r=Mark-Simulacrum

bootstrap: remove unneeded extern crate

The crate itself is internally referenced by serde_derive.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 29, 2017
… r=Mark-Simulacrum

bootstrap: remove unneeded extern crate

The crate itself is internally referenced by serde_derive.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 29, 2017
… r=Mark-Simulacrum

bootstrap: remove unneeded extern crate

The crate itself is internally referenced by serde_derive.
arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
… r=Mark-Simulacrum

bootstrap: remove unneeded extern crate

The crate itself is internally referenced by serde_derive.
arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
… r=Mark-Simulacrum

bootstrap: remove unneeded extern crate

The crate itself is internally referenced by serde_derive.
bors added a commit that referenced this pull request Aug 29, 2017
Rollup of 12 pull requests

- Successful merges: #43705, #43778, #43918, #44076, #44117, #44121, #44126, #44134, #44135, #44141, #44144, #44158
- Failed merges:
@bors bors merged commit 45d31ac into rust-lang:master Aug 30, 2017
@ishitatsuyuki ishitatsuyuki deleted the bootstrap-deps-purge branch August 30, 2017 00:56
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 1, 2017
bors added a commit that referenced this pull request Sep 1, 2017
[beta] Boostrap from released compilers

No need to use dev any more!

Also contains backports for:

* #44049
* #44121
* #44144
bors added a commit that referenced this pull request Sep 2, 2017
[beta] Boostrap from released compilers

No need to use dev any more!

Also contains backports for:

* #44049
* #44121
* #44144
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants