-
Notifications
You must be signed in to change notification settings - Fork 13.4k
rustbuild: Compile the error-index in stage 2 #44605
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Right now we comiple rustdoc in stage 2 and the error index in stage 0, which ends up compiling rustdoc twice! To avoid compiling rustdoc twice (which takes awhile) let's just compile it once in stage 2.
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=1 (perf win) |
📌 Commit 61e255a has been approved by |
…imulacrum rustbuild: Compile the error-index in stage 2 Right now we comiple rustdoc in stage 2 and the error index in stage 0, which ends up compiling rustdoc twice! To avoid compiling rustdoc twice (which takes awhile) let's just compile it once in stage 2.
⌛ Testing commit 61e255a with merge eae9a39b602d021a6c97112fd5e29d8223c02e68... |
💔 Test failed - status-travis |
@bors retry
|
rustbuild: Compile the error-index in stage 2 Right now we comiple rustdoc in stage 2 and the error index in stage 0, which ends up compiling rustdoc twice! To avoid compiling rustdoc twice (which takes awhile) let's just compile it once in stage 2.
☀️ Test successful - status-appveyor, status-travis |
…lacrum rustbuild: Build stage 1 error index generator at stage 0 At stage 1 rustdoc is built at stage 0 so the error index generator should be as well. This fixes `x.py --stage 1 doc` as rustdoc doesn't even build at stage 1. It was broken by #44605. r? @alexcrichton
Right now we comiple rustdoc in stage 2 and the error index in stage 0, which
ends up compiling rustdoc twice! To avoid compiling rustdoc twice (which takes
awhile) let's just compile it once in stage 2.