code suggestions for unused-mut, while-true, deprecated-attribute, and unused-parens lints #44942

zackmdavis · 2017-09-30T08:15:41Z

`CodeSuggestion` doesn't live in the `diagnostic` module.

estebank

Small nitpicks, r=me once you deal with the first two.

estebank · 2017-09-30T08:27:30Z

src/librustc_lint/builtin.rs

-                                    "denote infinite loops with loop { ... }");
+                        let msg = "denote infinite loops with `loop { ... }`";
+                        let mut err = cx.struct_span_lint(WHILE_TRUE,
+                                                          e.span, msg);


Fits in one line?

estebank · 2017-09-30T08:28:28Z

src/librustc_lint/builtin.rs

+                                                          e.span, msg);
+                        let condition_span = cx.tcx.sess.codemap().def_span(e.span);
+                        err.span_suggestion_short(condition_span, "use `loop`",
+                                                  "loop".to_owned());


When all arguments don't fit, I like to keep one line per argument (indented to the first one in the same line as the method).

estebank · 2017-09-30T08:29:55Z

src/librustc_lint/unused.rs

+                let mut err = cx.struct_span_lint(UNUSED_PARENS,
+                                                  value.span,
+                                                  &span_msg);
+                // Remove exactly one pair of parentheses (rather than naïvely


@nikomatsakis do we care about unicode in rustc comments?

zackmdavis · 2017-09-30T08:50:36Z

(force-pushed to address formatting review comments)

Also, fix the deprecation message for the late no-debug feature.

Resolves rust-lang#42892.

zackmdavis · 2017-09-30T18:32:50Z

(updated again to fix compile-fail failures reported by Travis)

estebank · 2017-10-01T01:00:50Z

@bors r+

Thanks @zachreizner, great work!

bors · 2017-10-01T01:00:50Z

📌 Commit a399757 has been approved by estebank

bors · 2017-10-01T03:58:37Z

⌛ Testing commit a3997577226db861d103d27da91a77acf9fd4b3e with merge 7a521317b909286b51aa36af0dee6cbd7a5cc6c0...

zackmdavis · 2017-10-01T04:11:52Z

Thanks @zachreizner, great work!

I agree; @zachreizner is the best! I especially like the one where he fixed the shift-right docs; it must have taken a very careful eye to catch that!

😉

zachreizner · 2017-10-01T04:15:00Z

Not the first time I've been thanked in place of a a fellow Zach :-). I think my handle just comes up before the Zack Zach-s in the autocomplete.

bors · 2017-10-01T04:43:59Z

💔 Test failed - status-appveyor

zackmdavis · 2017-10-01T23:18:37Z

Appveyor/Windows apparently doesn't like the --error-format json UI test. I think this is plausibly a bug in the test runner (rather than the JSON order being unstable or anything like that), since the only difference seems to be in the "file_name" value, which is supposed to be normalized (with "$DIR") and worked fine in the Travis/Unix-like tests, but for now I'll just rewrite it as a run-make test.

estebank · 2017-10-01T23:54:35Z

I believe we're really trying to move away from make tests. @zackmdavis, could you

create a ticket to deal with the test output normalization failure on json output and
revert your last change and add // ignore-windows to the test (this will make the test to be skipped under windows) with a comment linking to the previous ticket?

zackmdavis · 2017-10-02T01:43:31Z

output normalization issue is #44968; updated tip of PR with ignore-windows is 979671ec

zackmdavis · 2017-10-02T03:16:19Z

correction, PR is 8a14022

estebank · 2017-10-02T05:33:08Z

@bors r+ rollup

bors · 2017-10-02T05:33:09Z

📌 Commit 8a14022 has been approved by estebank

bors · 2017-10-02T07:03:32Z

⌛ Testing commit 8a14022 with merge 9ae6ed7...

@estebank

code suggestions for unused-mut, while-true, deprecated-attribute, and unused-parens lints ![lint_suggestions](https://user-images.githubusercontent.com/1076988/31044068-b2074de8-a57c-11e7-9319-6668508b6d1f.png) r? @estebank

bors · 2017-10-02T10:06:27Z

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing 9ae6ed7 to master...

@estebank

code suggestions for non-shorthand field pattern, no-mangle lints continuing in the spirit of #44942 ![moar_lint_suggestions](https://user-images.githubusercontent.com/1076988/31485011-3b20cc80-aee7-11e7-993d-81267ab77732.png) r? @estebank

@estebank

code suggestions for non-shorthand field pattern, no-mangle lints continuing in the spirit of #44942 ![moar_lint_suggestions](https://user-images.githubusercontent.com/1076988/31485011-3b20cc80-aee7-11e7-993d-81267ab77732.png) r? @estebank

@estebank

code suggestions for non-shorthand field pattern, no-mangle lints continuing in the spirit of #44942 ![moar_lint_suggestions](https://user-images.githubusercontent.com/1076988/31485011-3b20cc80-aee7-11e7-993d-81267ab77732.png) r? @estebank

fix comment typo, CodeSuggestion path in doc comment

d663003

`CodeSuggestion` doesn't live in the `diagnostic` module.

rust-highfive assigned estebank Sep 30, 2017

estebank approved these changes Sep 30, 2017

View reviewed changes

zackmdavis force-pushed the lint_suggestions branch from 15f4aa1 to 289faf5 Compare September 30, 2017 08:50

zackmdavis added 3 commits September 30, 2017 11:31

code suggestion for deprecated-attribute lint

f2c5acd

Also, fix the deprecation message for the late no-debug feature.

code suggestion for unused-parentheses lint

5c9f806

Resolves rust-lang#42892.

code suggestions for unused-mut, while-true lints; UI test

e3b4989

zackmdavis force-pushed the lint_suggestions branch from 289faf5 to a399757 Compare September 30, 2017 18:31

zackmdavis force-pushed the lint_suggestions branch from a399757 to fa8802a Compare October 1, 2017 23:25

zackmdavis mentioned this pull request Oct 2, 2017

UI test expectation path normalization not working on Windows in all cases? #44968

Closed

zackmdavis force-pushed the lint_suggestions branch from fa8802a to 979671e Compare October 2, 2017 01:38

correct unused-parens lint suggestion to strip exact pair

8a14022

zackmdavis force-pushed the lint_suggestions branch from 979671e to 8a14022 Compare October 2, 2017 03:15

bors merged commit 8a14022 into rust-lang:master Oct 2, 2017

This was referenced Oct 11, 2017

make easier/possible to detect derive attributes after expansion #45216

Open

code suggestions for non-shorthand field pattern, no-mangle lints #45232

Merged

zackmdavis deleted the lint_suggestions branch January 13, 2018 07:46

code suggestions for unused-mut, while-true, deprecated-attribute, and unused-parens lints #44942

code suggestions for unused-mut, while-true, deprecated-attribute, and unused-parens lints #44942

Uh oh!

Conversation

zackmdavis commented Sep 30, 2017

Uh oh!

estebank left a comment

Choose a reason for hiding this comment

Uh oh!

estebank Sep 30, 2017

Choose a reason for hiding this comment

Uh oh!

estebank Sep 30, 2017

Choose a reason for hiding this comment

Uh oh!

estebank Sep 30, 2017

Choose a reason for hiding this comment

Uh oh!

zackmdavis commented Sep 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zackmdavis commented Sep 30, 2017

Uh oh!

estebank commented Oct 1, 2017

Uh oh!

bors commented Oct 1, 2017

Uh oh!

bors commented Oct 1, 2017

Uh oh!

zackmdavis commented Oct 1, 2017

Uh oh!

zachreizner commented Oct 1, 2017

Uh oh!

bors commented Oct 1, 2017

Uh oh!

zackmdavis commented Oct 1, 2017

Uh oh!

estebank commented Oct 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zackmdavis commented Oct 2, 2017

Uh oh!

zackmdavis commented Oct 2, 2017

Uh oh!

estebank commented Oct 2, 2017

Uh oh!

bors commented Oct 2, 2017

Uh oh!

bors commented Oct 2, 2017

Uh oh!

bors commented Oct 2, 2017

Uh oh!

Uh oh!

zackmdavis commented Sep 30, 2017 •

edited

Loading

estebank commented Oct 1, 2017 •

edited

Loading