cleanup: rustc doesn't use an external archiver #45102
Merged
+9
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochenkov
commented
Oct 8, 2017
| # is not the linker used to link said compiler. | ||
| # The default linker that will be hard-coded into the generated compiler for | ||
| # targets that don't specify linker explicitly in their target specifications. | ||
| # Note that this is not the linker used to link said compiler. |
There was a problem hiding this comment.
A drive-by comment improvement.
|
☔ The latest upstream changes (presumably #45041) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me Thanks! |
carols10cents
added
the
S-waiting-on-author
|
@bors r=alexcrichton |
|
📌 Commit b434c84 has been approved by |
|
⌛ Testing commit b434c84 with merge 818c288b0ed69e03993c74ef8b45ebf077c8e216... |
|
💔 Test failed - status-travis |
|
@bors retry
|
bors
added a commit
that referenced
this pull request
Oct 14, 2017
cleanup: rustc doesn't use an external archiver cc #45090 r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #45090
r? @alexcrichton