Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Disable jemalloc for sparcv9-sun-solaris #45508

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Disable jemalloc for sparcv9-sun-solaris #45508

merged 1 commit into from
Oct 26, 2017

Conversation

bgermann
Copy link
Contributor

Similar to #36994, rust programs segfault on SPARC64 Solaris machines.

@bgermann
Disable jemalloc for sparcv9-sun-solaris
7bab5da 
Similar to #36994, rust programs segfault on SPARC64 Solaris machines.
@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Oct 25, 2017

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned eddyb Oct 25, 2017
@glaubitz
Copy link
Contributor

glaubitz commented Oct 25, 2017 •
edited
Loading

@bgermann Any idea whether this affects BSD and Linux on sparc64 as well?

Are you seeing #45509 on Solaris?

Edit: The change you made is already present on sparc64-unknown-linux-gnu, but not for -netbsd, so this wouldn't help with the crashes in #45509. I would be very interested to hear whether you are seeing these crashes on sparcv9-sun-solaris. Since they affect alignment, they should be visible on your SPARC target as well.

@bgermann
Copy link
Contributor Author

No, I am seeing

fatal runtime error: allocator memory exhausted
Illegal Instruction - core dumped

This workaround is used on Linux as well, so I guess that NetBSD also segfaults. I do not have one running, so I cannot confirm it.

@bgermann
Copy link
Contributor Author

I only cross compile to Solaris SPARC, so unfortunately I cannot say anything about a native compilation as in #45509.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 25, 2017

📌 Commit 7bab5da has been approved by alexcrichton

kennytm added a commit to kennytm/rust that referenced this pull request Oct 25, 2017
@kennytm
Rollup merge of rust-lang#45508 - bgermann:master, r=alexcrichton
5ae94d4 
Disable jemalloc for sparcv9-sun-solaris

Similar to rust-lang#36994, rust programs segfault on SPARC64 Solaris machines.
@kennytm kennytm mentioned this pull request Oct 25, 2017
Merged
bors added a commit that referenced this pull request Oct 25, 2017
@bors
Auto merge of #45532 - kennytm:rollup, r=kennytm
e847f30 
Rollup of 7 pull requests

- Successful merges: #45059, #45212, #45398, #45483, #45496, #45508, #45526
- Failed merges:
@bors bors merged commit 7bab5da into rust-lang:master Oct 26, 2017
@bgermann
Copy link
Contributor Author

I would like to beta-nominate this.

@kennytm kennytm added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2017
@bgermann bgermann mentioned this pull request Oct 26, 2017
Merged
bors added a commit that referenced this pull request Oct 31, 2017
@bors
Auto merge of #45559 - bgermann:beta, r=alexcrichton
ff845fa 
[beta] Disable jemalloc for sparcv9-sun-solaris

Backport from #45508. Similar to #36994, rust programs segfault on SPARC64 Solaris machines.
bors added a commit that referenced this pull request Nov 2, 2017
@bors
Auto merge of #45559 - bgermann:beta, r=alexcrichton
7d3dcc8 
[beta] Disable jemalloc for sparcv9-sun-solaris

Backport from #45508. Similar to #36994, rust programs segfault on SPARC64 Solaris machines.
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 2, 2017
@nikomatsakis
Copy link
Contributor

Approved for backport. Very small PR. But looks like it already happened anyway in #45559.

@nikomatsakis nikomatsakis removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 2, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bgermann @rust-highfive @eddyb @glaubitz @alexcrichton @bors @nikomatsakis @kennytm