Skip to content

fixes to MIR effectck #45785

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Nov 10, 2017
Merged

fixes to MIR effectck #45785

merged 3 commits into from
Nov 10, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Nov 5, 2017

r? @eddyb

beta-nominating because regression (MIR effectck is new)

@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 5, 2017
@@ -148,6 +148,8 @@ define_maps! { <'tcx>
/// the value isn't known except to the pass itself.
[] fn mir_const_qualif: MirConstQualif(DefId) -> (u8, Rc<IdxSetBuf<mir::Local>>),

[] fn mir_raw: MirRaw(DefId) -> &'tcx Steal<mir::Mir<'tcx>>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be named build_mir or something similar instead?

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2017
@arielb1 arielb1 changed the title slightly WIP: fixes to MIR effectck fixes to MIR effectck Nov 6, 2017
@eddyb
Copy link
Member

eddyb commented Nov 7, 2017

@bors r+

cc @nikomatsakis

@bors
Copy link
Collaborator

bors commented Nov 7, 2017

📌 Commit 12aedc8 has been approved by eddyb

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2017
@bors
Copy link
Collaborator

bors commented Nov 10, 2017

⌛ Testing commit 12aedc8 with merge 968b620...

bors added a commit that referenced this pull request Nov 10, 2017
fixes to MIR effectck

r? @eddyb

beta-nominating because regression (MIR effectck is new)
@bors
Copy link
Collaborator

bors commented Nov 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 968b620 to master...

@bors bors merged commit 12aedc8 into rust-lang:master Nov 10, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 14, 2017
fixes to MIR effectck

r? @eddyb

beta-nominating because regression (MIR effectck is new)
@arielb1 arielb1 mentioned this pull request Nov 14, 2017
bors added a commit that referenced this pull request Nov 14, 2017
@nikomatsakis nikomatsakis added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 16, 2017
@nikomatsakis
Copy link
Contributor

Backported in #45986.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants