Allow a trailling comma in assert_eq/ne macro #45887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
force-pushed
the
assert-eq-trailling-comma
branch
from
344c59f to
9b2e78a
Compare
kennytm
added
S-waiting-on-review
|
cc @rust-lang/libs @zackmdavis |
|
By the way, |
KamilaBorowska
force-pushed
the
assert-eq-trailling-comma
branch
from
9b2e78a to
5e1f697
Compare
KamilaBorowska
force-pushed
the
assert-eq-trailling-comma
branch
from
5e1f697 to
6a92c0f
Compare
|
@bors r+ |
|
📌 Commit 6a92c0f has been approved by |
kennytm
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 10, 2017
…tolnay Allow a trailling comma in assert_eq/ne macro From Rust beginners IRC: <???> It sure does annoy me that assert_eq!() does not accept a trailing comma after the last argument. <???> ???: File an issue against https://github.com/rust-lang/rust and CC @rust-lang/libs Figured that might as well submit it. Will become insta-stable after merging (danger zone). cc @rust-lang/libs
bors
added a commit
that referenced
this pull request
Nov 10, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Rust beginners IRC:
<???> It sure does annoy me that assert_eq!() does not accept a trailing comma after the last argument.
<???> ???: File an issue against https://github.com/rust-lang/rust and CC @rust-lang/libs
Figured that might as well submit it. Will become insta-stable after merging (danger zone).
cc @rust-lang/libs