fix linking error on i586 #45991
Merged
fix linking error on i586 #45991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 5146663 has been approved by |
kennytm
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 17, 2017
fix linking error on i586 Try to fix this linking error on i586 in cross: https://travis-ci.org/japaric/cross/builds/302095949#L8670 The problem is that `std` is built in Ubuntu 16.04 and `cross` uses a linker from 12.04. Currently this fix solves the problem for `i686-musl` making it "supercompatible", this PR applies the fix to `i586` as well. The cross PR is here: cross-rs/cross#157
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix this linking error on i586 in cross:
https://travis-ci.org/japaric/cross/builds/302095949#L8670
The problem is that
stdis built in Ubuntu 16.04 andcrossuses a linker from 12.04.Currently this fix solves the problem for
i686-muslmaking it "supercompatible", this PR applies the fix toi586as well.The cross PR is here: cross-rs/cross#157