Fix borrowck compiler errors for upvars contain "spurious" dereferences #46087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vramana
force-pushed
the
fix-46003
branch
2 times, most recently
from
fe6b3bf to
9c9d094
Compare
nikomatsakis
approved these changes
Nov 19, 2017
src/librustc_mir/borrow_check.rs
Outdated
| if autoderef { | ||
| self.append_lvalue_to_string(&proj.base, buf, Some(autoderef)); | ||
| } else { | ||
| buf.push_str(&"(*"); |
nikomatsakis
approved these changes
Nov 19, 2017
|
@bors r+ We'll let the paren thing sort itself out in rebasing. =) |
|
📌 Commit 9c9d094 has been approved by |
kennytm
added
the
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #46040) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Needs rebase. =) |
vramana
force-pushed
the
fix-46003
branch
2 times, most recently
from
4be9b35 to
5cf3e2e
Compare
|
@nikomatsakis Done. |
|
@nikomatsakis Seems like an unrelated build failure. |
|
You accidentally pushed a submodule update, please fix that |
|
@bors r+ |
|
📌 Commit 392e513 has been approved by |
|
@bors r+ |
|
📌 Commit d059b57 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 23, 2017
Fix borrowck compiler errors for upvars contain "spurious" dereferences Fixes #46003
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46003