Skip to content

[beta] Update rustfmt and rls #46145

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 25, 2017
Merged

[beta] Update rustfmt and rls #46145

merged 1 commit into from
Nov 25, 2017

Conversation

nrc
Copy link
Member

@nrc nrc commented Nov 21, 2017

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2017
@kennytm
Copy link
Member

kennytm commented Nov 21, 2017

Note: This PR should not be merged before #46140

@alexcrichton
Copy link
Member

I've cherry-picked this into #46140 to hopefully reduce cycle time, so closing

@alexcrichton
Copy link
Member

Ah I ended up backing this out due to test failures, so I'll reopen!

@nrc
Copy link
Member Author

nrc commented Nov 21, 2017

Do you have a link to the test failures? Looks like we're passing Travis here.

@kennytm
Copy link
Member

kennytm commented Nov 21, 2017

@nrc #46140 (comment)

The CI running on the PR doesn't test RLS, BTW.

@nrc
Copy link
Member Author

nrc commented Nov 23, 2017

@bors: r=alexcrichton

@bors
Copy link
Collaborator

bors commented Nov 23, 2017

📌 Commit fdb013b has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2017
@bors
Copy link
Collaborator

bors commented Nov 25, 2017

⌛ Testing commit fdb013b with merge 6b15f7d...

bors added a commit that referenced this pull request Nov 25, 2017
@bors
Copy link
Collaborator

bors commented Nov 25, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6b15f7d to beta...

@bors bors merged commit fdb013b into rust-lang:beta Nov 25, 2017
@kennytm kennytm mentioned this pull request Nov 25, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants