Md warnings

[GuillaumeGomez]

Fixes #45365.

r? @QuietMisdreavus

[QuietMisdreavus]

Is there a way we can somehow combine this chunk of code with the one below and with https://github.com/GuillaumeGomez/rust/blob/92c38d31e4f3797517d1a33619eb2628758cf464/src/librustdoc/html/render.rs#L1838-L1843 so we don't have three copies of the "render this markdown twice" code? (I'm thinking some kind of function that takes a RenderType and returns a string so it can also be used right here?)

[GuillaumeGomez]

I was thinking about it as well but every solution seems more like a boilerplate than a real solution. I'll give it a deeper look.

[QuietMisdreavus]

So my thinking is something like this, in html/render.rs so it can be used alongside USED_ID_MAP:

fn render_text<F: FnMut(RenderType) -> String>(render: F) -> (String, String) {
    // (original comment about saving USED_ID_MAP)
    let orig_used_id_map = USED_ID_MAP.with(|map| map.borrow().clone());
    let hoedown_output = render(text, RenderType::Hoedown);
    USED_ID_MAP.with(|map| *map.borrow_mut() = orig_used_id_map);
    let pulldown_output = render(text, RenderType::Pulldown);
    (hoedown_output, pulldown_output)
}

...and then it could be called like this:

render_text(|type| format!("{}", Markdown(text, type)));
render_text(|type| format!("{}", MarkdownWithToc(text, type)));

[GuillaumeGomez]

Totally seems like a boilerplate haha. I'll give it a try. ;)

[QuietMisdreavus]

I don't see how refactoring this to combine the code would be called "boilerplate", but if you think it would be too much effort i can just drop it.

[QuietMisdreavus]

Can you export render_text and use it here? (That's why i brought it up in the first place. >_>)

[shepmaster]

Checking in from triage — it looks like it's up to @GuillaumeGomez to make some suggested changes, yes?

[QuietMisdreavus]

That or some kind of field report for having tried them out and rejecting them. The rest of the PR is good.

[GuillaumeGomez]

I need to apply @QuietMisdreavus' suggestions. I didn't have time yet.

[GuillaumeGomez]

@QuietMisdreavus: Updated. The new code looks way better. Great suggestion!

[QuietMisdreavus]

r=me pending travis

[GuillaumeGomez]

@bors: r=QuietMisdreqvus

[bors]

📌 Commit eb84f42 has been approved by QuietMisdreqvus

[bors]

⌛ Testing commit eb84f42 with merge ab79caa...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreqvus
Pushing ab79caa to master...