Shorten output of E0391 #46282
Merged
Shorten output of E0391 #46282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
reviewed
Nov 27, 2017
There was a problem hiding this comment.
The output of issue-23305.rs is also affected.
error[E0391]: unsupported cyclic reference between types/traits detected
--> $DIR/issue-23305.rs:15:12
|
15 | impl ToNbt<Self> {}
| ^^^^ cyclic reference
|
note: the cycle begins when processing `<impl at $DIR/issue-23305.rs:15:1: 15:20>`...
--> $DIR/issue-23305.rs:15:1
|
15 | impl ToNbt<Self> {}
- | ^^^^^^^^^^^^^^^^^^^
+ | ^^^^^^^^^^^^^^^^
= note: ...which then again requires processing `<impl at $DIR/issue-23305.rs:15:1: 15:20>`, completing the cycle.
error: aborting due to previous error| --> $DIR/auto-trait-leak.rs:52:1 | ||
| | | ||
| 52 | fn cycle1() -> impl Clone { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Actual output differs from expected output. Please update.
error[E0391]: unsupported cyclic reference between types/traits detected
--> $DIR/auto-trait-leak.rs:52:1
|
-52 | fn cycle1() -> impl Clone {
- | ^^^^^^^^^^^^^^^^^^^^^^^^^ cyclic reference
+52 | fn cycle1() -> impl Clone {
+ | _-^^^^^^^^^^^^^^^^^^^^^^^^
+53 | | //~^ ERROR unsupported cyclic reference between types/traits detected
+54 | | //~| cyclic reference
+55 | | //~| NOTE the cycle begins when processing `cycle1`...
+... |
+60 | | Rc::new(Cell::new(5))
+61 | | }
+ | |_- cyclic referenceThere was a problem hiding this comment.
Missed the label. Done.
kennytm
added
the
S-waiting-on-review
estebank
force-pushed
the
impl-trait-cicle-span
branch
from
35e28f4 to
487daab
Compare
|
@bors r+ rollup |
|
📌 Commit 487daab has been approved by |
kennytm
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 27, 2017
…rielb1 Shorten output of E0391 Use the shorter `def_span` on the impl-Trait cyclic reference errors.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the shorter
def_spanon the impl-Trait cyclic reference errors.