[auto-toolstate][2+3/8] Move external tools tests into its own job with --no-fail-fast #46393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-author
kennytm
force-pushed
the
45861-step-2-3-make-tools-job-not-fail-fast
branch
15 times, most recently
from
5e36d9c to
5cf368a
Compare
kennytm
changed the title
kennytm
added
S-waiting-on-review
|
cc @nrc |
|
📌 Commit 5cf368a has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 5cf368a1e560131af48f5f7d877c512f3c32ebbd with merge 33b67152932620802d845805f16c9739ea44c6ff... |
|
💔 Test failed - status-appveyor |
kennytm
force-pushed
the
45861-step-2-3-make-tools-job-not-fail-fast
branch
from
5cf368a to
b52fc12
Compare
|
@bors r=alexcrichton Windows folder separator + Bash = 😱 |
|
📌 Commit b52fc12 has been approved by |
|
⌛ Testing commit b52fc127a1fedfda80d8064cd6be8b6e72b5197e with merge 24ded9606540ef195d29a09cb6ec638effb4e73b... |
|
💔 Test failed - status-appveyor |
The cargotest job is renamed to tools for clarification.
kennytm
force-pushed
the
45861-step-2-3-make-tools-job-not-fail-fast
branch
from
b52fc12 to
1839645
Compare
|
@bors r=alexcrichton |
|
📌 Commit 1839645 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 3, 2017
…-fast, r=alexcrichton [auto-toolstate][2+3/8] Move external tools tests into its own job with --no-fail-fast This PR performs these things: 1. The `aux` job now performs "cargotest" and "pretty" tests. The clippy/rustfmt/rls/miri tests are moved into its own job. 2. These tests are run with `--no-fail-fast`, so that we can get the maximum number of failures of all tools from a single CI run. 3. The test results are stored into a JSON file, ready to be uploaded in the future. This is step 2 and 3/8 of automatic management of broken tools #45861.
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs these things:
auxjob now performs "cargotest" and "pretty" tests. The clippy/rustfmt/rls/miri tests are moved into its own job.--no-fail-fast, so that we can get the maximum number of failures of all tools from a single CI run.This is step 2 and 3/8 of automatic management of broken tools #45861.