rustc_mir: don't move temporaries that are still used later. #46492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-blocked
|
r=me if we still want this |
|
Note however travis failures. |
|
Also, test? |
eddyb
removed
the
S-blocked
kennytm
added
the
S-waiting-on-author
|
r? @arielb1 |
|
@bors r+ |
|
📌 Commit 2a629f9 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 5, 2017
rustc_mir: don't move temporaries that are still used later. This should unbreak using the MIR borrow-checker on `libcore` (assuming #46268 is merged).
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should unbreak using the MIR borrow-checker on
libcore(assuming #46268 is merged).