-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add armv5te-unknown-linux-gnueabi to cross builder #46498
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Thanks! I'm surprised it worked as-is :) Out of curiosity, is this a target you're planning on using or is this mostly just for completeness? |
8838b02
to
af3bb30
Compare
CC and CFLAGS are missing (rust-lang/cc-rs#271)
Just for completeness 😄. |
86a2242
to
b9304dc
Compare
It worked on travis too. The last commit removes the try from .travis.yml |
☔ The latest upstream changes (presumably #46499) made this pull request unmergeable. Please resolve the merge conflicts. |
b9304dc
to
bea65d4
Compare
Rebased. |
Ok, we can always continue to iterate on it I think as well! @bors: r+ |
📌 Commit bea65d4 has been approved by |
Add armv5te-unknown-linux-gnueabi to cross builder This is the only linux target missing in the dist builders.
☀️ Test successful - status-appveyor, status-travis |
Interested in this for use on a Lego EV3. Able to build a hello world just fine but I get an immediate segfault running it on the device or on QEMU. |
@green-s I also get segfault when running in qemu... I made some mistake, because I thought I got it working before making this PR... Sorry, but I cannot take a look at this now. |
Reverts rust-lang#46498 I must have made some mistake when I tested that commit and thought armv5te target worked. but testing it now the produced binaries segfaults (rust-lang#46498 (comment)). I tried using crosstool-ng and buildroot toolchain (for armv5te) but the produced binaries also segfaults. Maybe there is a issue with the target, but I cannot investigate it any further. I think the best for now is not to distribute the armv5te target. I'm sorry for what happened.
Remove armv5te target from dist-various-1 Reverts #46498 I must have made some mistake when I tested that commit and thought armv5te target worked. but testing it now the produced binaries segfaults (#46498 (comment)). I tried using crosstool-ng and buildroot toolchain (for armv5te) but the produced binaries also segfaults. Maybe there is a issue with the target, but I cannot investigate it any further. I think the best for now is not to distribute the armv5te target. I'm sorry for what happened.
Today I tried
it crash in But the same code compiled by |
@Dushistov I've opened an issue #46822. Thanks. |
Codegen seems fixed in the latest nightly. Is this ok to be resubmitted? |
This is the only linux target missing in the dist builders.