Skip to content

Add armv5te-unknown-linux-gnueabi to cross builder #46498

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

malbarbo
Copy link
Contributor

@malbarbo malbarbo commented Dec 4, 2017

This is the only linux target missing in the dist builders.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 4, 2017
@alexcrichton
Copy link
Member

Thanks! I'm surprised it worked as-is :)

Out of curiosity, is this a target you're planning on using or is this mostly just for completeness?

@malbarbo
Copy link
Contributor Author

malbarbo commented Dec 4, 2017

Thanks! I'm surprised it worked as-is :)

CC and CFLAGS are missing (rust-lang/cc-rs#271)
It worked locally, I'm trying it on travis.

Out of curiosity, is this a target you're planning on using or is this mostly just for completeness?

Just for completeness 😄.

@malbarbo malbarbo force-pushed the dist-armv5te branch 2 times, most recently from 86a2242 to b9304dc Compare December 5, 2017 00:18
@malbarbo
Copy link
Contributor Author

malbarbo commented Dec 5, 2017

It worked on travis too. The last commit removes the try from .travis.yml

@bors
Copy link
Collaborator

bors commented Dec 5, 2017

☔ The latest upstream changes (presumably #46499) made this pull request unmergeable. Please resolve the merge conflicts.

@malbarbo
Copy link
Contributor Author

malbarbo commented Dec 5, 2017

Rebased.

@alexcrichton
Copy link
Member

Ok, we can always continue to iterate on it I think as well!

@bors: r+

@bors
Copy link
Collaborator

bors commented Dec 5, 2017

📌 Commit bea65d4 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2017
@bors
Copy link
Collaborator

bors commented Dec 5, 2017

⌛ Testing commit bea65d4 with merge abe85ab...

bors added a commit that referenced this pull request Dec 5, 2017
Add armv5te-unknown-linux-gnueabi to cross builder

This is the only linux target missing in the dist builders.
@bors
Copy link
Collaborator

bors commented Dec 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing abe85ab to master...

@bors bors merged commit bea65d4 into rust-lang:master Dec 5, 2017
@green-s
Copy link
Contributor

green-s commented Dec 11, 2017

Interested in this for use on a Lego EV3. Able to build a hello world just fine but I get an immediate segfault running it on the device or on QEMU.

@malbarbo
Copy link
Contributor Author

@green-s I also get segfault when running in qemu... I made some mistake, because I thought I got it working before making this PR... Sorry, but I cannot take a look at this now.

malbarbo added a commit to malbarbo/rust that referenced this pull request Dec 12, 2017
Reverts rust-lang#46498

I must have made some mistake when I tested that commit and thought
armv5te target worked. but testing it now the produced binaries
segfaults
(rust-lang#46498 (comment)).

I tried using crosstool-ng and buildroot toolchain (for armv5te) but
the produced binaries also segfaults. Maybe there is a issue with the
target, but I cannot investigate it any further.

I think the best for now is not to distribute the armv5te target.

I'm sorry for what happened.
bors added a commit that referenced this pull request Dec 12, 2017
Remove armv5te target from dist-various-1

Reverts #46498

I must have made some mistake when I tested that commit and thought armv5te target worked. but testing it now the produced binaries segfaults (#46498 (comment)).

I tried using crosstool-ng and buildroot toolchain (for armv5te) but the produced binaries also segfaults. Maybe there is a issue with the target, but I cannot investigate it any further.

I think the best for now is not to distribute the armv5te target.

I'm sorry for what happened.
@Dushistov
Copy link
Contributor

Dushistov commented Dec 18, 2017

@malbarbo

Today I tried rustc 1.24.0-nightly (8503b3ff8 2017-12-04) and produced binary from such simple code segfaults:

fn main() {
    let mut f: f32 = 1.5;
    println!("test: {}", f);
    f = f * 1.4 + 1.3;
    println!("test: {}", f);
}

it crash in __sync_val_compare_and_swap_4, almost all other examples of code also crash in this place.

But the same code compiled by rustc 1.23.0-nightly (ee2286149 2017-11-07)
run without any problems and produce expecting results. So it is some kind of regression in code generator.

@malbarbo
Copy link
Contributor Author

@Dushistov I've opened an issue #46822. Thanks.

@green-s
Copy link
Contributor

green-s commented Dec 26, 2017

Codegen seems fixed in the latest nightly. Is this ok to be resubmitted?

bors added a commit that referenced this pull request Dec 27, 2017
Add dist builder for armv5te-unknown-linux-gnueabi (again)

The dist builder was first add in #46498 and later remove in #46498 because of #46822.

#46822 seems to be fixed now (I and @green-s have [tested](#46498 (comment)) it).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants