Skip to content

Backport #46385 #46729

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Dec 16, 2017
Merged

Backport #46385 #46729

merged 3 commits into from
Dec 16, 2017

Conversation

steveklabnik
Copy link
Member

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
@rust-highfive
Copy link
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Dec 14, 2017

📌 Commit 336a27c has been approved by alexcrichton

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 14, 2017
@kennytm
Copy link
Member

kennytm commented Dec 14, 2017

🤔 CI is failing because external factors are still not fixed.

@steveklabnik Could you backport #46715 and #46694 together? Otherwise I'm afraid bors won't be happy (yes http://crosstool-ng.org/ is still offline).

@steveklabnik
Copy link
Member Author

I can try to roll them into these PRs...

Temporary workaround since crosstool-ng.org was down. Consider mirroring
the release tarball as a more permanent solution.
@steveklabnik
Copy link
Member Author

Let's see how this goes.

@steveklabnik
Copy link
Member Author

Looks like it passed!

@bors: r=alexcrichton

@bors
Copy link
Collaborator

bors commented Dec 14, 2017

📌 Commit bc3e2ae has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Dec 16, 2017

⌛ Testing commit bc3e2ae with merge 3ab24df...

@bors
Copy link
Collaborator

bors commented Dec 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3ab24df to beta...

@bors bors merged commit bc3e2ae into rust-lang:beta Dec 16, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants