Skip to content

Fix the wrong subtraction in align_offset intrinsic. #46812

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2017
Merged

Fix the wrong subtraction in align_offset intrinsic. #46812

merged 1 commit into from
Dec 19, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Dec 18, 2017

Given how the stage0 implementation in #43903 is written, as well as that in the RFC, I suppose the current implementation has a typo.

cc #44488, cc @oli-obk.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Dec 18, 2017

Hmm curious. I guess it worked because it was just an optimization.

We should probably kill the stage cfg now that it's in stage0

@kennytm
Copy link
Member Author

kennytm commented Dec 18, 2017 •
edited
Loading

The stage0 should have been killed 😄. I'm just pointing out that it is align - offset everywhere else but the actual implementation used offset - align.

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 18, 2017

📌 Commit 749d8a8 has been approved by petrochenkov

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 18, 2017
@GuillaumeGomez
Rollup merge of rust-lang#46812 - kennytm:fix-align-offset-sign, r=pe…
c68c4b5 
…trochenkov

Fix the wrong subtraction in align_offset intrinsic.

Given how the stage0 implementation in rust-lang#43903 is written, as well as that in the RFC, I suppose the current implementation has a typo.

cc rust-lang#44488, cc @oli-obk.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 18, 2017
Merged
bors added a commit that referenced this pull request Dec 19, 2017
@bors
Auto merge of #46829 - GuillaumeGomez:rollup, r=GuillaumeGomez
c8b94c6 
Rollup of 11 pull requests

- Successful merges: #46700, #46786, #46790, #46800, #46801, #46802, #46804, #46805, #46812, #46824, #46825
- Failed merges:
@bors bors merged commit 749d8a8 into rust-lang:master Dec 19, 2017
@kennytm kennytm deleted the fix-align-offset-sign branch December 19, 2017 12:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennytm @rust-highfive @oli-obk @petrochenkov @bors