-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
tweaks and fixes for doc(include) #46858
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Hmm, I wonder if the |
@jonhoo What happens with |
Right now, empty doc comments and doc attributes will satisfy the |
I think that an empty included doc file should be consistent with empty doc-comments. If we want to change what that does, maybe discuss it in a separate issue or PR. |
@bors r+ |
📌 Commit cbbb73b has been approved by |
@bors rollup |
… r=estebank tweaks and fixes for doc(include) This PR makes a handful of changes around `#[doc(include="file.md")]` (rust-lang#44732): * Turns errors when loading files into full errors. This matches the original RFC text. * Makes the `missing_docs` lint check for `#[doc(include="file.md")]` as well as regular `#[doc="text"]` attributes. * Loads files included by `#[doc(include="file.md")]` into dep-info, mirroring the behavior of `include_str!()` and friends. * Adds or modifies tests to check for all of these.
This PR makes a handful of changes around
#[doc(include="file.md")]
(#44732):missing_docs
lint check for#[doc(include="file.md")]
as well as regular#[doc="text"]
attributes.#[doc(include="file.md")]
into dep-info, mirroring the behavior ofinclude_str!()
and friends.