Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Updating Contributor Covenant links #46954

Merged
merged 1 commit into from
Dec 28, 2017
Merged

Updating Contributor Covenant links #46954

merged 1 commit into from
Dec 28, 2017

Conversation

davidalber
Copy link
Contributor

The current link 301s to a new destination.

$ curl -I http://contributor-covenant.org/version/1/3/0/
HTTP/1.1 301 Moved Permanently
Cache-Control: public, max-age=0, must-revalidate
Content-Length: 0
Content-Type: text/plain
Date: Fri, 22 Dec 2017 21:13:09 GMT
Location: https://www.contributor-covenant.org/version/1/3/0/
Age: 1
Connection: keep-alive
Server: Netlify

rust-lang/prev.rust-lang.org#994 fixes this in the Rust site.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm
Copy link
Member

kennytm commented Dec 23, 2017

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 23, 2017

📌 Commit e450d35 has been approved by kennytm

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 23, 2017
@kennytm kennytm mentioned this pull request Dec 23, 2017
Closed
@kennytm kennytm mentioned this pull request Dec 23, 2017
Closed
@davidalber
Copy link
Contributor Author

This conflicts with #46939. I'll rebase this and resolve the conflict after #46939 merges.

@bors
Copy link
Contributor

bors commented Dec 25, 2017

⌛ Testing commit e450d35f31173433795207e451ed0373b81784e0 with merge 943b53a482bbd7e320eac3bf1b8d12551f49b27f...

@bors
Copy link
Contributor

bors commented Dec 25, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Dec 25, 2017 •
edited
Loading

@bors retry #47002

@bors
Copy link
Contributor

bors commented Dec 26, 2017

⌛ Testing commit e450d35f31173433795207e451ed0373b81784e0 with merge 5a7c39effd8bf6017e320c8734ed203fb386b486...

@bors
Copy link
Contributor

bors commented Dec 26, 2017

💔 Test failed - status-travis

@bors
Copy link
Contributor

bors commented Dec 26, 2017

☔ The latest upstream changes (presumably #47012) made this pull request unmergeable. Please resolve the merge conflicts.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 26, 2017
@kennytm
Copy link
Member

kennytm commented Dec 26, 2017

@davidalber #46939 has been merged, you can rebase on master now.

@davidalber
Updating Contributor Covenant links
a087733 
The current link 301s to a new destination.
@davidalber davidalber force-pushed the fix-contributor-covenant-link branch from e450d35 to a087733 Compare December 26, 2017 17:28
@davidalber
Copy link
Contributor Author

Done. Thanks, @kennytm. And thanks for unjamming CI!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 26, 2017

📌 Commit a087733 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 26, 2017
@bors
Copy link
Contributor

bors commented Dec 28, 2017

⌛ Testing commit a087733 with merge 4352c11...

bors added a commit that referenced this pull request Dec 28, 2017
@bors
Auto merge of #46954 - davidalber:fix-contributor-covenant-link, r=al…
4352c11 
…excrichton

Updating Contributor Covenant links

The current link 301s to a new destination.

```sh
$ curl -I http://contributor-covenant.org/version/1/3/0/
HTTP/1.1 301 Moved Permanently
Cache-Control: public, max-age=0, must-revalidate
Content-Length: 0
Content-Type: text/plain
Date: Fri, 22 Dec 2017 21:13:09 GMT
Location: https://www.contributor-covenant.org/version/1/3/0/
Age: 1
Connection: keep-alive
Server: Netlify
```

rust-lang/prev.rust-lang.org#994 fixes this in the Rust site.
@bors
Copy link
Contributor

bors commented Dec 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4352c11 to master...

@bors bors merged commit a087733 into rust-lang:master Dec 28, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidalber @rust-highfive @kennytm @bors @alexcrichton