-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Mechanical translation towards making GlobalCtxt implement Sync #46958
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #46842) made this pull request unmergeable. Please resolve the merge conflicts. |
ping @michaelwoerister, did you want to take a look at this? |
Nominating for discussion in the @rust-lang/compiler team meeting. This is a huge change that I can't approve by myself. Also, I think we should have a broader, more open discussion about multi-threading support in the compiler. I feel that such a thing would need an RFC. |
I've insistented on numerous occasions on IRC that It is plausible that you get some speedup even with locks everywhere but it's not ideal IMO. |
I do feel like parallelizing rustc seems like a good goal but I would like to see some more design discussion. That said, I don't know that I have an objection to this PR in particular, which seems like it's probably necessary groundwork? If I understand what's happening here, we're basically just redirecting names on the basis of a configuration option? (i.e., we're still going to be using That said, I think I might prefer to use names Thoughts? |
That is indeed what is happening.
There are a couple of problems with that.
|
We discussed this in the @rust-lang/compiler meeting. Consensus was that @Zoxc would open a thread on internals and we would try to ensure we have some level of agreement on the overall plan before we go forward. Closing PR for now. |
This PR is split out from #45912.