renumber regions in generators #47353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't actually fix the bug, but seems better.
shepmaster
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit ea742a4 has been approved by |
pnkfelix
added
S-waiting-on-bors
|
@bors r=pnkfelix |
|
📌 Commit bca536d has been approved by |
spastorino
force-pushed
the
nll-issue-47189
branch
from
8279632 to
3593780
Compare
|
@bors r=pnkfelix The final commit is actually r=me. |
|
📌 Commit 3d3c75a has been approved by |
|
@bors r- travis is unhappy, something with mir-opt tests |
nikomatsakis
force-pushed
the
nll-issue-47189
branch
from
3d3c75a to
8f2cc02
Compare
|
@bors r=pnkfelix+nmatsakis |
|
📌 Commit 8f2cc02 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 22, 2018
…akis renumber regions in generators This fixes #47189, but I think we still have to double check various things around how to treat generators in MIR type check + borrow check (e.g., what borrows should be invalidated by a `Suspend`? What consistency properties should type check be enforcing anyway around the "interior" type?) Also fixes #47587 thanks to @spastorino's commit. r? @pnkfelix
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #47189, but I think we still have to double check various things around how to treat generators in MIR type check + borrow check (e.g., what borrows should be invalidated by a
Suspend? What consistency properties should type check be enforcing anyway around the "interior" type?)Also fixes #47587 thanks to @spastorino's commit.
r? @pnkfelix