Skip to content

Avoid panicking when invalid argument is passed to cfg(..) #47372

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2018
Merged

Avoid panicking when invalid argument is passed to cfg(..) #47372

merged 1 commit into from
Jan 15, 2018

Conversation

topecongiro
Copy link
Contributor

@topecongiro topecongiro commented Jan 12, 2018 •
edited
Loading

Closes #43925.
Closes #43926.

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@topecongiro
Copy link
Contributor Author

Updated the PR to handle when cfg(..) has no argument (cc #43926).

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2018
@arielb1
Copy link
Contributor

arielb1 commented Jan 13, 2018

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Thanks @topecongiro!

@bors
Copy link
Collaborator

bors commented Jan 13, 2018

📌 Commit d088b25 has been approved by alexcrichton

@kennytm kennytm mentioned this pull request Jan 15, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Jan 15, 2018
@kennytm
Rollup merge of rust-lang#47372 - topecongiro:issue-43925, r=alexcric…
f98a9a6 
…hton

Avoid panicking when invalid argument is passed to cfg(..)

Closes rust-lang#43925.
Closes rust-lang#43926.
bors added a commit that referenced this pull request Jan 15, 2018
@bors
Auto merge of #47445 - kennytm:rollup, r=kennytm
57850e5 
Rollup of 10 pull requests

- Successful merges: #47120, #47126, #47277, #47330, #47368, #47372, #47414, #47417, #47432, #47443
- Failed merges: #47334
@bors bors merged commit d088b25 into rust-lang:master Jan 15, 2018
@topecongiro topecongiro deleted the issue-43925 branch January 15, 2018 15:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@topecongiro @rust-highfive @arielb1 @alexcrichton @bors @pnkfelix @shepmaster