Skip to content

rustc_trans: take into account primitives larger than 8 bytes. #47437

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jan 14, 2018

Fixes #38763 by marking all "eightbytes" covered by a primitive appropriately, not just the first.

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member Author

eddyb commented Jan 15, 2018

r? @nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned pnkfelix Jan 15, 2018
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2018
@nagisa
Copy link
Member

nagisa commented Jan 15, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 15, 2018

📌 Commit 5934174 has been approved by nagisa

@bors
Copy link
Collaborator

bors commented Jan 16, 2018

☔ The latest upstream changes (presumably #47209) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb
Copy link
Member Author

eddyb commented Jan 16, 2018

@bors r=nagisa

@bors
Copy link
Collaborator

bors commented Jan 16, 2018

📌 Commit cbeebc5 has been approved by nagisa

@shepmaster shepmaster added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 25, 2018
rustc_trans: take into account primitives larger than 8 bytes.

Fixes rust-lang#38763 by marking all "eightbytes" covered by a primitive appropriately, not just the first.
@kennytm
Copy link
Member

kennytm commented Jan 26, 2018

@bors r-

This PR failed in the rollup #47748 because Emscripten doesn't support i128. Please apply 68f2e1e:

From 68f2e1ebf2e0f959685fbce3f69349b3e21f34cc Mon Sep 17 00:00:00 2001
From: Alex Crichton <alex@alexcrichton.com>
Date: Thu, 25 Jan 2018 21:04:01 -0800
Subject: [PATCH] Ignore an i128 test on emscripten

---
 src/test/run-pass/issue-38763.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/test/run-pass/issue-38763.rs b/src/test/run-pass/issue-38763.rs
index 4bf9513d64f9..01cc8265a399 100644
--- a/src/test/run-pass/issue-38763.rs
+++ b/src/test/run-pass/issue-38763.rs
@@ -8,6 +8,8 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
+// ignore-emscripten
+
 #![feature(i128_type)]
 
 #[repr(C)]

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 26, 2018
@eddyb
Copy link
Member Author

eddyb commented Jan 26, 2018

@bors r=nagisa

@bors
Copy link
Collaborator

bors commented Jan 26, 2018

📌 Commit 035eee8 has been approved by nagisa

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2018
bors added a commit that referenced this pull request Jan 26, 2018
@kennytm
Copy link
Member

kennytm commented Jan 26, 2018

Already merged as part of #47748 😀

@kennytm kennytm closed this Jan 26, 2018
@eddyb eddyb deleted the issue-38763 branch January 26, 2018 22:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i128] ICE when calling function with #[repr(C)]'d tuple struct
7 participants