-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
rustdoc: Remove methods from #[doc(masked)] crates from the search index #47675
Conversation
Could you verify if this fixes #44740? |
Indeed it does. |
@bors r+ rollup Thanks! |
📌 Commit 2e81ce7 has been approved by |
@bors r- Not your fault, but unfortunately a test case is invalid, causing failure after the bug is fixed. Please apply the following diff: diff --git a/src/test/rustdoc-js/from_u.js b/src/test/rustdoc-js/from_u.js
index 0296788f7a..34b98a758d 100644
--- a/src/test/rustdoc-js/from_u.js
+++ b/src/test/rustdoc-js/from_u.js
@@ -15,7 +15,5 @@ const EXPECTED = {
{ 'path': 'std::char', 'name': 'from_u32' },
{ 'path': 'std::str', 'name': 'from_utf8' },
{ 'path': 'std::string::String', 'name': 'from_utf8' },
- { 'path': 'std::i32', 'name': 'from_unsigned' },
- { 'path': 'std::i128', 'name': 'from_unsigned' },
],
}; |
@bors r=QuietMisdreavus |
📌 Commit 77bc826 has been approved by |
Is it possible for travis to run those tests automatically? They seem like they will be pretty fragile. |
@ollie27 Those tests should be run automatically, but it seems the CI docker image is missing nodejs.
|
For example: https://doc.rust-lang.org/nightly/std/?search=from_parts
Fixes #44740
r? @QuietMisdreavus