Let LLVM 5 add DW_OP_deref to indirect args itself #47688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to manually added the `DW_OP_deref` ourselves in earlier LLVM, but starting with [D31439] in LLVM 5, it appears that LLVM will always handle this itself. When we were still adding this manually, the resulting `.debug_loc` had too many derefs, and this failed test `debuginfo/by-value-self-argument-in-trait-impl.rs`. [D31439]: https://reviews.llvm.org/D31439 Fixes rust-lang#47611. cc @alexcrichton r? @michaelwoerister
kennytm
added
the
S-waiting-on-review
18 tasks
|
Ah I think @michaelwoerister is on leave for a bit, so given the fact that this should pass tests before/after LLVM updates I'm going to r+. If this is in error though I'm sure we can find another solution that also passes all the tests everywhere! @bors: r+ |
|
📌 Commit 7eb7d45 has been approved by |
workingjubilee
added
the
A-LLVM
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to manually added the
DW_OP_derefourselves in earlier LLVM,but starting with D31439 in LLVM 5, it appears that LLVM will always
handle this itself. When we were still adding this manually, the
resulting
.debug_lochad too many derefs, and this failed testdebuginfo/by-value-self-argument-in-trait-impl.rs.Fixes #47611.
cc @alexcrichton
r? @michaelwoerister