-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Automatically enable the clippy
feature of rls
if clippy builds
#48097
Automatically enable the clippy
feature of rls
if clippy builds
#48097
Conversation
src/bootstrap/lib.rs
Outdated
#![feature( | ||
associated_consts, | ||
slice_concat_ext, | ||
)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why expand this into 4 lines 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So future changes to the feature list are simpler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually just write multiple #![feature]
attributes though
@bors: r+ |
📌 Commit 8a4ca24 has been approved by |
@bors r- Cannot find the commit
|
☔ The latest upstream changes (presumably #48202) made this pull request unmergeable. Please resolve the merge conflicts. |
8a4ca24
to
99f774e
Compare
rebased and adjusted submodule references |
@bors r=nrc |
📌 Commit 99f774e has been approved by |
☔ The latest upstream changes (presumably #48476) made this pull request unmergeable. Please resolve the merge conflicts. |
Ping from triage, @oli-obk! It's been a few weeks since we've heard from you, will you have time to address the merge conflicts? |
19557b0
to
6fa8d33
Compare
@bors r=nrc |
📌 Commit 6fa8d33 has been approved by |
📌 Commit 6f15e82 has been approved by |
@bors r- you don't need to waste time on this now that the miri PR broke clippy |
☔ The latest upstream changes (presumably #48549) made this pull request unmergeable. Please resolve the merge conflicts. |
6f15e82
to
02ac15c
Compare
Do not merge before rust-lang/rls#768 is merged |
rust-lang/rls#768 was merged |
@bors r=nrc |
📌 Commit 02ac15c has been approved by |
…=nrc Automatically enable the `clippy` feature of `rls` if clippy builds r? @nrc cc @Manishearth
☀️ Test successful - status-appveyor, status-travis |
Tested on commit rust-lang/rust@55c984e. Direct link to PR: <rust-lang/rust#48097> 🎉 clippy-driver on windows: build-fail → test-fail. 🎉 clippy-driver on linux: build-fail → test-fail.
This field was introduced in rust-lang#48097 to support the "clippy" feature of RLS.
r? @nrc
cc @Manishearth