Remove allocation from width of character function. #48167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ rollup |
|
📌 Commit f237e9e has been approved by |
bors
added
the
S-waiting-on-bors
Mark-Simulacrum
added
the
beta-nominated
|
I've nominated this for beta backport, as it's a small patch that fixes a major regression (40 minute long compile times vs 150 seconds), and if we cut beta before this lands (likely) this is good to get in. |
Mark-Simulacrum
added
the
beta-accepted
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 13, 2018
…odemap, r=estebank Remove allocation from width of character function. Locally this seems to eliminate the problem or at least resolve most of the issue. Fixes rust-lang#48153. r? @estebank
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 14, 2018
…odemap, r=estebank Remove allocation from width of character function. Locally this seems to eliminate the problem or at least resolve most of the issue. Fixes rust-lang#48153. r? @estebank
bors
added a commit
that referenced
this pull request
Feb 14, 2018
bors
added a commit
that referenced
this pull request
Feb 15, 2018
|
@rust-lang/release Would anyone be interested in making a beta backport of this? Process is described here: https://forge.rust-lang.org/beta-backporting.html |
|
@Mark-Simulacrum I'll take this one if it's no problem. |
kennytm
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Mar 4, 2018
[beta] Remove allocation from width of character function. Backport of #48167 r? @Mark-Simulacrum
bors
added a commit
that referenced
this pull request
Mar 5, 2018
[beta] Remove allocation from width of character function. Backport of #48167 r? @Mark-Simulacrum
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally this seems to eliminate the problem or at least resolve most of the
issue.
Fixes #48153.
r? @estebank