auto: librustc: Allow mutable box substructure to be borrowed without requirin... #4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring purity. Closes rust-lang#4825.
|
I thought that we didn't want to allow these sorts of borrows? I was planning on ensuring that they can't happen. In particular I expect the for loop there to yield an error since you are borrowing a substructure of an |
|
OK, but I feel like that error should be emitted deliberately, not only allowed if pure. |
|
OK. r+ |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2020
clone_on_copy - add machine applicability Fix rust-lang#4826. Change the applicability of the lint clone_on_copy. Split a test file and run rustfix on the clone_on_copy part. changelog: clone_on_copy - add machine applicability
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...g purity. Closes #4825.
r? @nikomatsakis