Skip to content

Update RLS #48349

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2018
Merged

Update RLS #48349

merged 1 commit into from
Mar 1, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented Feb 19, 2018

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 19, 2018
@alexcrichton
Copy link
Member

@bors: r+ p=10

@bors
Copy link
Collaborator

bors commented Feb 20, 2018

📌 Commit 7327c21 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2018
@bors
Copy link
Collaborator

bors commented Feb 20, 2018

⌛ Testing commit 7327c21 with merge 35d43b9dd71731476e3b92cb64682668199d5f48...

@Manishearth
Copy link
Member

(Something's weird with the homu queue, will reopen)

@bors clean retry

@Manishearth Manishearth reopened this Feb 20, 2018
@Manishearth
Copy link
Member

@bors clean retry

@bors
Copy link
Collaborator

bors commented Feb 20, 2018

⌛ Testing commit 7327c21 with merge becda682c17563fd47422c979925c095718b6d11...

@bors
Copy link
Collaborator

bors commented Feb 20, 2018

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 20, 2018
@bors
Copy link
Collaborator

bors commented Feb 20, 2018

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Feb 20, 2018

@bors retry

3 hour timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2018
@bors
Copy link
Collaborator

bors commented Feb 20, 2018

⌛ Testing commit 7327c21 with merge 186e01bafd744f1addbfa90730535648d8a1cd8f...

@bors
Copy link
Collaborator

bors commented Feb 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 186e01bafd744f1addbfa90730535648d8a1cd8f to master...

@kennytm
Copy link
Member

kennytm commented Feb 21, 2018

@bors retry

Failed to merge

@bors
Copy link
Collaborator

bors commented Feb 21, 2018

⌛ Testing commit 7327c21 with merge ddab3c9e5bedc2eff590198c6faaa61867598d0c...

@bors
Copy link
Collaborator

bors commented Feb 21, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2018
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2018
@nrc
Copy link
Member Author

nrc commented Feb 26, 2018

@bors: r=alexcrichton

@bors
Copy link
Collaborator

bors commented Feb 26, 2018

📌 Commit 4dd7877 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@bors
Copy link
Collaborator

bors commented Feb 26, 2018

⌛ Testing commit 4dd787760fb4b074bb343d41aa1f60bc5f367bd3 with merge 969cd130cdef87aa4094eba41773a442569a39c9...

@bors
Copy link
Collaborator

bors commented Feb 26, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@kennytm
Copy link
Member

kennytm commented Feb 26, 2018

test_all_targets failed.

[01:20:57] failures:
[01:20:57] 
[01:20:57] ---- test::test_all_targets stdout ----
[01:20:57] 	expect_messages:
[01:20:57]   results: [
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"id\":0,\"result\":{\"capabilities\":{\"textDocumentSync\":2,\"hoverProvider\":true,\"completionProvider\":{\"resolveProvider\":true,\"triggerCharacters\":[\".\",\":\"]},\"definitionProvider\":true,\"referencesProvider\":true,\"documentHighlightProvider\":true,\"documentSymbolProvider\":true,\"workspaceSymbolProvider\":true,\"codeActionProvider\":true,\"documentFormattingProvider\":true,\"documentRangeFormattingProvider\":false,\"renameProvider\":true,\"executeCommandProvider\":{\"commands\":[\"rls.applySuggestion\",\"rls.deglobImports\"]}}}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_7\",\"title\":\"Build\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_7\",\"message\":\"bin_lib\",\"title\":\"Build\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_7\",\"message\":\"bin_lib\",\"title\":\"Build\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_7\",\"message\":\"tests\",\"title\":\"Build\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_7\",\"message\":\"bin_lib\",\"title\":\"Build\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_7\",\"message\":\"bin_lib\",\"title\":\"Build\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"done\":true,\"id\":\"progress_7\",\"title\":\"Build\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"id\":\"progress_6\",\"title\":\"Diagnostics\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"textDocument/publishDiagnostics\",\"params\":{\"diagnostics\":[{\"code\":\"unused_variables\",\"message\":\"unused variable: `unused_var`\\n\\nnote: #[warn(unused_variables)] on by default\\nhelp: consider using `_unused_var` instead: `_unused_var`\",\"range\":{\"end\":{\"character\":18,\"line\":2},\"start\":{\"character\":8,\"line\":2}},\"severity\":2,\"source\":\"rustc\"}],\"uri\":\"file:///checkout/src/tools/rls/test_data/bin_lib/tests/tests.rs\"}}",
[01:20:57]     "{\"jsonrpc\":\"2.0\",\"method\":\"window/progress\",\"params\":{\"done\":true,\"id\":\"progress_6\",\"title\":\"Diagnostics\"}}"
[01:20:57] ],
[01:20:57]   expected: [
[01:20:57]     ExpectedMessage {
[01:20:57]         id: Some(
[01:20:57]             0
[01:20:57]         ),
[01:20:57]         contains: [
[01:20:57]             "capabilities"
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "progress",
[01:20:57]             "title\":\"Build\""
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "progress",
[01:20:57]             "message"
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "progress",
[01:20:57]             "message"
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "progress",
[01:20:57]             "message"
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "progress",
[01:20:57]             "message"
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "progress",
[01:20:57]             "message"
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "progress",
[01:20:57]             "\"done\":true"
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "progress",
[01:20:57]             "title\":\"Diagnostics\""
[01:20:57]         ]
[01:20:57]     },
[01:20:57]     ExpectedMessage {
[01:20:57]         id: None,
[01:20:57]         contains: [
[01:20:57]             "bin_lib/tests/tests.rs",
[01:20:57]             "unused variable: `unused_var`"
[01:20:57]         ]
[01:20:57]     }
[01:20:57] ]
[01:20:57] thread 'test::test_all_targets' panicked at 'assertion failed: `(left == right)`
[01:20:57]   left: `11`,
[01:20:57]  right: `10`', tools/rls/src/test/harness.rs:223:5
[01:20:57] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:20:57] 
[01:20:57] 
[01:20:57] failures:
[01:20:57]     test::test_all_targets
[01:20:57] 
[01:20:57] test result: FAILED. 42 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

@nrc nrc mentioned this pull request Feb 26, 2018
Closed
@nrc
Copy link
Member Author

nrc commented Feb 28, 2018

@bors: r=alexcrichton

@bors
Copy link
Collaborator

bors commented Feb 28, 2018

📌 Commit 4b6f5c2 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Feb 28, 2018

🌲 The tree is currently closed for pull requests below priority 200, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2018
@Manishearth
Copy link
Member

@bors treeclosed-

@bors
Copy link
Collaborator

bors commented Mar 1, 2018

⌛ Testing commit 4b6f5c2 with merge a85417f...

bors added a commit that referenced this pull request Mar 1, 2018
@bors
Auto merge of #48349 - nrc:update, r=alexcrichton
a85417f 
Update RLS

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Mar 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a85417f to master...

@bors bors merged commit 4b6f5c2 into rust-lang:master Mar 1, 2018
This was referenced Mar 1, 2018
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nrc @alexcrichton @bors @Manishearth @kennytm @pietroalbini