make #[unwind] attribute specify expectations more clearly
#48380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
force-pushed
the
issue-48251-master
branch
2 times, most recently
from
a6cfafc to
175619a
Compare
kennytm
reviewed
Feb 20, 2018
src/libsyntax/attr.rs
Outdated
| Aborts, | ||
| } | ||
|
|
||
| /// Determine what `#[inline]` attribute is present in `attrs`, if any. |
nikomatsakis
force-pushed
the
issue-48251-master
branch
2 times, most recently
from
d8287cf to
2dadb12
Compare
You can now choose between the following: - `#[unwind(allowed)]` - `#[unwind(aborts)]` Per rust-lang#48251, the default is `#[unwind(allowed)]`, though I think we should change this eventually.
nikomatsakis
force-pushed
the
issue-48251-master
branch
from
2dadb12 to
a47fd3d
Compare
|
@bors: r+ Thanks @nikomatsakis! I hope that soon this won't be necessary in the sense that users won't have to decorate apis with attributes in an on-demand fashion, but this is all unstable anyway so seems like a fine interim solution! |
|
📋 Looks like this PR is still in progress, ignoring approval |
nikomatsakis
changed the title
#[unwind] attribute specify expectations more clearly#[unwind] attribute specify expectations more clearly
|
@bors r=acrichto |
|
📌 Commit 566c6ac has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 28, 2018
…acrichto Fixes rust-lang#47311. r? @nrc
|
Even with this PR, the logic in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now choose between the following:
#[unwind(allowed)]#[unwind(aborts)]Per #48251, the default is
#[unwind(allowed)], thoughI think we should change this eventually.