Skip to content

Add nonstandard_style alias for bad_style. #48386

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Feb 25, 2018

Conversation

withoutboats
Copy link
Contributor

@withoutboats withoutboats commented Feb 20, 2018

No description provided.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@withoutboats
Copy link
Contributor Author

r? @Manishearth

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2018
@Manishearth
Copy link
Member

This isn't enough, right now the bad_style lint group will still be shown in the rustc -W help output.

What needs to be done is to rename the lint group and add a silent alias for backwards compatibility.

(also the interaction of overlapping lint groups is kinda iffy)

r=me for landing this as is though.

@withoutboats
Copy link
Contributor Author

Changed the comment to not close the tracking issue, this can be a good first step.

@Manishearth
Copy link
Member

@bors r+

A simple slightly-hacky way to do this would be to simply treat it as a different name when parsing lint group names.

@bors
Copy link
Collaborator

bors commented Feb 20, 2018

📌 Commit 6fe5f42 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2018
mod bad {
fn CamelCase() {} //~ ERROR should have a snake

static bad: isize = 1; //~ ERROR should have an upper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a downer.

@kennytm
Copy link
Member

kennytm commented Feb 21, 2018

@bors r=Manishearth

@bors
Copy link
Collaborator

bors commented Feb 21, 2018

📌 Commit 5949d8b has been approved by Manishearth

@mark-i-m
Copy link
Member

Lol, why? I'm not sure I understand the motivation for this...

@steveklabnik
Copy link
Member

@mark-i-m #41646

@mark-i-m
Copy link
Member

Oh, it seems I missed quite an epic thread. It's good to know decisions like that are not made lightly, even though I don't fully agree with the change :)

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2018
…anishearth

Add nonstandard_style alias for bad_style.
bors added a commit that referenced this pull request Feb 25, 2018
Rollup of 15 pull requests

- Successful merges: #47689, #48110, #48197, #48296, #48386, #48392, #48404, #48415, #48441, #48448, #48452, #48481, #48490, #48499, #48503
- Failed merges:
@bors bors merged commit 5949d8b into rust-lang:master Feb 25, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants