-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add nonstandard_style alias for bad_style. #48386
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
r? @Manishearth |
This isn't enough, right now the bad_style lint group will still be shown in the What needs to be done is to rename the lint group and add a silent alias for backwards compatibility. (also the interaction of overlapping lint groups is kinda iffy) r=me for landing this as is though. |
Changed the comment to not close the tracking issue, this can be a good first step. |
@bors r+ A simple slightly-hacky way to do this would be to simply treat it as a different name when parsing lint group names. |
📌 Commit 6fe5f42 has been approved by |
mod bad { | ||
fn CamelCase() {} //~ ERROR should have a snake | ||
|
||
static bad: isize = 1; //~ ERROR should have an upper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a downer.
@bors r=Manishearth |
📌 Commit 5949d8b has been approved by |
Lol, why? I'm not sure I understand the motivation for this... |
Oh, it seems I missed quite an epic thread. It's good to know decisions like that are not made lightly, even though I don't fully agree with the change :) |
…anishearth Add nonstandard_style alias for bad_style.
No description provided.